no hibernate with uswsusp installed

[Ralf Meyer]

Binary package hint: acpi-support

Ubuntu version: 7.04
ii uswsusp 0.3~cvs20060928-6ubuntu3 tools to use userspace software suspend provided by Linux
ii acpi-support 0.95 a collection of useful events for acpi

I have upgraded Ubuntu from 6.10 to 7.04. Hibernate doesn't work out of the box. The problem seems to be this (from /etc/acpi/hibernate.sh):
---
    if [ -f /etc/usplash.conf ]; then
        . /etc/usplash.conf
        /sbin/s2disk -x "$xres" -y "$yres" $DEVICE
 ---
s2disk is called with -x and -y parameters which s2disk doesn't like.

Without these parameters it works.

[ThomasGillespie (tomjamesgillespie)]

Can confirm here

[Ralf Meyer (ranf)]

Actually I consider this to be a regression in package: uswsusp.

It worked in Edgy with usplash.

[Ralf Meyer (ranf)]

Thomas,

can you please set the Status to "confirmed"?

[Stefan Fleiter (stefan-fleiter)]

This problem is still present in current gutsy.

[Peter Meiser (meiser79)]

Hi, I added a patch for this to LP bug 82283.

[Peter Meiser (meiser79)]

Hi,

please have a look at the attached debdiff. It fixes lost usplash support and implements -x and -y command line parameter.

It compiles fine, but I could not test it on a live system.

Best regards,
Whoopie

[Peter Meiser (meiser79)]

updated debdiff.

[Peter Meiser (meiser79)]

needed patch for acpi-support

[Peter Meiser (meiser79)]

latest changes to usplash automaticly fixes LP #114688 when uswsusp is rebuilt. So, no manual adding to Depends is needed anymore.

[Peter Meiser (meiser79)]

two things which must be looked into:

1) /etc/uswsusp.conf must have "/dev/sdaX" instead of the UUID.
2) usplash progress bar hangs at 100% on resume. Thanks to Tollef Fog Heen, it can be "fixed" with Alt + sysrq + k

[Marcin Stępnicki (mstepnicki)]

Please provide updated package before Gutsy Final - this breaks critical functionality and fix is easily available.

[Peter Meiser (meiser79)]

Marcin, does it mean that my patch is working for you? No hangs on resume?

[Marcin Stępnicki (mstepnicki)]

On 10/16/07, Whoopie <email address hidden> wrote:
> Marcin, does it mean that my patch is working for you? No hangs on
> resume?

I am afraid I didn't make myself clear, sorry. I simply removed -x and
-y parameters as mentioned in original report and forgot about
splashscreen. I'll try to test your patch for a moment.

That being said, I've got another bug. When someone upgrades the
kernel and then hibernates it's impossible to restore the hibernated
state. While booting Ubuntu just displays blinking cursor. Using
alt+f1 or alt+f7 (I forgot) one may display the message which says (in
English) that kernel has changed and therefore hibernated state cannot
be restored, do you want to continue, state will be lost (y/n). I see
three major problems here:

#1 - hibernate should be disabled from menu after kernel upgrade
#2 - the aforementioned message should be visible, and
#3 - localized, as most users wouldn't be able to react properly.

I lack skills to do #1 and #2, I'll try and see if this warning
message can be translated.

Thank you for your work.

[alm (alm)]

The patch fixes usplash support with uswsusp for me, but I also get the hang at 100%. The hang occurs at suspend.c:restore_console(), in the VT_WAITACTIVE ioctl. It never returns, possibly because it's locked by svgalib and only unlocked in the atexit handler. With this ioctl() commented out, resume works. It won't switch console afterwards, and the terminal looks messy, but acpi-support duplicates the console switch, so it works fine when called via acpi-support/gnome-power-manager instead of calling s2disk directly. I'm not if the rest of restore_console() still works without the console switch, maybe it should just be replaced by close(fd) in the usplash case.

It may be different with the BOGL usplash backend. The chvt actually works without usplash. Not sure about splashy/bootsplash. Maybe uswsusp should use usplash's switch_console() if CONFIG_USPLASH, so usplash_restore_console() works. The usplash binary does this, and it seems to work.

It might also be a good idea to call usplash_done() in usplash_finish(), although it seems largely a NOP with the svgalib backend.

[MarcH (marc-h38)]

Please note that the $DEVICE argument is also wrong.

[Davide Castellone (kastel88)]

This bug hasn't been solved in Hardy. We could forget about the splash screen and simply make hibernate.sh work with s2disk.

[Viktor Kojouharov (vkojouharov)]

This bug hasn't been fixed in Intrepid either. How hard is it to remove -x and -y from a file?

[Khashayar Naderehvandi (khashayar)]

Wow, this is almost embarrassing. I'll nominate this bug for Jaunty...

[Chow Loong Jin (hyperair)]

I believe s2disk is called from pm-utils, not ACPI. Are you sure this bug is correct?

[Chow Loong Jin (hyperair)]

I'm moving this to acpi-support because it's not a fault of uswsusp, but acpi-support, considering /etc/acpi/hibernate.sh is a file belonging to acpi-support.

Either way I'd like to report that hibernate with uswsusp works just fine on Intrepid.

[Steve Langasek (vorlon)]

Since Ubuntu 9.10, hibernate has been handled via pm-utils; so this old script is no longer an issue. Marking as resolved.