wrong s2disk parameters invoked by hibernate.sh in acpi-support 0.95 when /etc/usplash.conf is present

[Adriano Provvisiero]

Binary package hint: acpi-support

hibernate.sh in acpi-support 0.95 checks for the presence of s2disk, then checks for /etc/usplash.conf. If such two conditions are met, hibernate.sh invokes s2disk in the following way:

/sbin/s2disk -x "$xres" -y "$yres" $DEVICE

this is not working with the s2disk binary provided in uswsusp 0.3~cvs20060928-6ubuntu3. The -x and -y parameters aren't supported in this version, and hibernation doesn't proceed. This effectively ends up with a locked screen and a perfectly active system. Changing the line to invoke s2disk without -x and -y works flawlessly. usplash.conf is present on my laptop, so I assume the two parameters aren't needed anymore (just a black screen, no graphic glitches whatsoever when hibernating without them).. if such assumption is true, the whole if-fi block could be shrunk down to:

if [ -x /sbin/s2disk ]; then
    DEVICE="/dev/disk/by-uuid/`awk -F= '{print $3}' </etc/initramfs-tools/conf.d/resume`"
    /sbin/s2disk $DEVICE
else
    echo -n "disk" >/sys/power/state
fi

Thanks for taking the time!
nuu

[Cristian Klein (cristiklein)]

I confirm that this problem occurs on Ubuntu 7.04 on an IBM R51 Laptop, and that the above changes solve it.

[Ralf Meyer (ranf)]

I've set status to confirmed.

Possible duplicate of #109151

[Matthew Garrett (mjg59)]

Somebody mismerged the Debian package for uswsusp.

[Marcin Stępnicki (mstepnicki)]

I can confirm this with A31p & Gutsy.

[MarcH (marc-h38)]

$DEVICE argument looks wrong too.