Comment 6 for bug 108742

Revision history for this message
Siegfried Gevatter (rainct) wrote :

ORIGINAL MAINTAINER
Now there's a typo there (Origional). Also, the new maintainer you added (the MOTU mailing list) was OK.
(https://wiki.ubuntu.com/DebianMaintainerField)

INSTALLING THE "pixmaps" DIR
Sorry, could not look at the package yesterday. You should not create a "dirs" file, since the previous maintainers weren't using any, but instead add a "dh_installdirs usr/share/pixmaps" (after "dh_installdirs usr/share/applications") on the debian/rules file.

CHANGELOG
It's OK now (although you could start the line with a capital letter, but that isn't that important :P). I've seen now that the package hasn't been updated since over a year, so that's why you don't see any other "(LP: #xxxxx)" there, but that's how it should be written now. If it would be a Debian bug it would be written like "(Closes: #xxxxx)" (just for the case you'd like to know that ;), it doesn't matter for this fix).

Also, you are deleting a line of the previous entry ("acidrip (0.14-0.2ubuntu4) edgy; urgency=low"). This should remain untouched.

ICON NAME
That's OK now, too. The extension should never be written because in the case that the file is available in many formats then, if it has no extension, automatically the most appropriate one will be chosen.

DELETION OF FILES
Don't delete that file called "1", it doesn't get installed anyway. Everything outside the "debian" directory comes from the original tarball and should be avoided to touch, or left to Debian (if it's required to be changed for the package to work, then a patch should be created, like those in debian/patches, but this isn't the case).

Thanks for your help improving Ubuntu :)