Comment 4 for bug 2031534

Revision history for this message
Simon Chopin (schopin) wrote :

todo: provide a PPA link

In general, it's nice to give a link to a PPA where the proposed code has been shown to build fine, but it's especially important to do so when shipping new upstream code, as those might contain binary files that debdiffs can't represent. It also ensures that we all build from the same upstream orig tarball, although that's not an issue in this precise case since this is a native package.
Could you give a link to such a PPA?

===

praise: Packaging is in good shape, I particularly appreciate the nice changelog entry :)

===

suggestion (not-blocking): Packaging looks fine, but I'm a bit puzzled as to why you're using RUSTFLAGS to disable the linux raw backend rather than using features?

If you'd add a dependency on rustix with that feature in your Cargo.toml, the vendoring code should automatically cull the linux-raw-sys crate from the dep tree, which would remove a fairly sizeable dependency, and prevent potential behaviour difference between running the code from the repo and from the package.

Given the looming FF, I'm perfectly fine with the idea of putting this suggestion off for a later version.