Release aad-auth 0.5

Bug #2031534 reported by Denison Barbosa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
aad-auth (Ubuntu)
Fix Released
Medium
Unassigned
Mantic
Fix Released
Medium
Unassigned

Bug Description

aad-auth (0.5) mantic; urgency=medium

  * Update Go version to 1.20
  * Update MSAL version to 1.1
  * Specify default scopes for authentication
    - After MSAL 1.0, the API no longer provides a set of default scopes in
      case none was specified. So now we specify the authentication scopes
      manually.
  * Normalize names used in NSS queries
    - Lowercase the names used in all queries to account for the case
      insensitivity of AAD.
  * Consider effective UID/GID when evaluating access to Shadow database:
    - This fixes the issue where AAD users could not open sudo sessions, even
      though they were part of the sudo group
  * Improved errors messages
    - Show link(s) to error code(s) description on Microsoft's site
  * Update dependencies to latest:
    ** Go
      - github.com/mattn/go-sqlite3
      - github.com/sirupsen/logrus
      - github.com/spf13/cobra
      - github.com/stretchr/testify
      - golang.org/x/crypto
      - golang.org/x/sys
    ** Rust
      - cc
      - ctor
      - goldenfile
      - libc
      - log
      - paste
      - proc-macro2
      - rusqlite
      - serde
      - serde_yaml
      - simple_logger
      - syslog
      - tempfile
      - test-case
      - time
  * Update CI dependencies not related to package functionality:
    - github.com/golangci/golangci-lint
    - actions/setup-go
    - peter-evans/create-pull-request

PPA with the builds: https://launchpad.net/~justdenis/+archive/ubuntu/mantic-release-aad

Tags: patch
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "debdiff from 0.4 to 0.5" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Revision history for this message
Simon Chopin (schopin) wrote :

todo: provide a PPA link

In general, it's nice to give a link to a PPA where the proposed code has been shown to build fine, but it's especially important to do so when shipping new upstream code, as those might contain binary files that debdiffs can't represent. It also ensures that we all build from the same upstream orig tarball, although that's not an issue in this precise case since this is a native package.
Could you give a link to such a PPA?

===

praise: Packaging is in good shape, I particularly appreciate the nice changelog entry :)

===

suggestion (not-blocking): Packaging looks fine, but I'm a bit puzzled as to why you're using RUSTFLAGS to disable the linux raw backend rather than using features?

If you'd add a dependency on rustix with that feature in your Cargo.toml, the vendoring code should automatically cull the linux-raw-sys crate from the dep tree, which would remove a fairly sizeable dependency, and prevent potential behaviour difference between running the code from the repo and from the package.

Given the looming FF, I'm perfectly fine with the idea of putting this suggestion off for a later version.

Revision history for this message
Simon Chopin (schopin) wrote :

Erf, spoke too soon on the linux-raw-sys, even when enabling the "use-libc" feature it still pulls in the dependency, since they didn't mark it as optional. That's a shame.

Revision history for this message
Denison Barbosa (justdenis) wrote (last edit ):

@schopin, thanks for the feedback! I appreciate it!

- The linux-raw dependency interaction is very annoying, indeed. Sadly, there isn't much we can do about it.

- Here's the PPA link with the builds: https://launchpad.net/~justdenis/+archive/ubuntu/mantic-release-aad

description: updated
description: updated
description: updated
Revision history for this message
Denison Barbosa (justdenis) wrote :
Changed in aad-auth (Ubuntu Mantic):
status: New → Fix Released
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.