configure)
# FIXME: do this with alternatives plymouth-set-default-theme --rebuild-initrd sabily
;;
First, this isn't safe; if the user has this package installed but chooses to use a different theme, that choice will be clobbered on every upgrade.
Second, the code to implement update-alternatives handling of themes is already in place in the bzr branch at lp:ubuntu/plymouth, and will be uploaded shortly. Please implement compatible handling in your package, and if necessary add a versioned dependency on plymouth 0.8.1-1, so that your package will play well with the theme handling targeted for lucid from the first upload.
Third, this theme has been constructed by cut-and-pasting the ubuntu-logo theme from the plymouth package, and that theme is still actively under development - you need to implement this in a way that doesn't duplicate the bugs whatever bugs happen to be in the current ubuntu-logo code. I would suggest that the correct way to accomplish this is by having your package Depend on plymouth-theme-ubuntu-logo and reference /lib/plymouth/themes/ubuntu-logo/ubuntu-logo.script directly as the ScriptFile in sabily.plymouth - then you just need to provide the same image set under the same names but in the /lib/plymouth/themes/sabily directory.
Provided that these packaging issues are addressed, FFe granted - this package is a clear successor to usplash-theme-sabily and sabily-xsplash-artwork and should be permitted in so we don't regress from karmic.
The postinst script in the package on REVU has:
configure)
plymouth- set-default- theme --rebuild-initrd sabily
# FIXME: do this with alternatives
;;
First, this isn't safe; if the user has this package installed but chooses to use a different theme, that choice will be clobbered on every upgrade.
Second, the code to implement update-alternatives handling of themes is already in place in the bzr branch at lp:ubuntu/plymouth, and will be uploaded shortly. Please implement compatible handling in your package, and if necessary add a versioned dependency on plymouth 0.8.1-1, so that your package will play well with the theme handling targeted for lucid from the first upload.
Third, this theme has been constructed by cut-and-pasting the ubuntu-logo theme from the plymouth package, and that theme is still actively under development - you need to implement this in a way that doesn't duplicate the bugs whatever bugs happen to be in the current ubuntu-logo code. I would suggest that the correct way to accomplish this is by having your package Depend on plymouth- theme-ubuntu- logo and reference /lib/plymouth/ themes/ ubuntu- logo/ubuntu- logo.script directly as the ScriptFile in sabily.plymouth - then you just need to provide the same image set under the same names but in the /lib/plymouth/ themes/ sabily directory.
Provided that these packaging issues are addressed, FFe granted - this package is a clear successor to usplash- theme-sabily and sabily- xsplash- artwork and should be permitted in so we don't regress from karmic.