Use Qt::AA_ShareOpenGLContexts and drop Qt private headers usage
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Online Accounts setup for Ubuntu Touch |
Fix Released
|
Undecided
|
Alberto Mardegan | ||
Ubuntu HTML5 UI SDK |
Fix Released
|
High
|
Alexandre Abreu | ||
webbrowser-app |
Fix Released
|
Medium
|
Olivier Tilloy | ||
ubuntu-html5-theme (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
ubuntu-system-settings-online-accounts (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
webbrowser-app (Ubuntu) |
Fix Released
|
Undecided
|
Olivier Tilloy |
Bug Description
Update: Qt 5.4 provides Qt::AA_
More information about Qt 5.4 at: https:/
--- original report ---
There's a critical bug that is being fixed with the following MP:
This bug is about removing the need for that, since using private headers causes extra pain for Qt migrations and we should minimize their usage.
Could Oxide provide this somehow else, so that only Oxide would use the private headers (like it already does)?
Update: not blocker for Qt 5.4, but simply something that would help Qt transitions in future by removing 5 packages from the transition list
Related branches
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 108 lines (+22/-9)4 files modifiedsrc/app/CMakeLists.txt (+5/-1)
src/app/browserapplication.cpp (+8/-6)
src/app/webbrowser/webbrowser-app.cpp (+5/-1)
src/app/webcontainer/webapp-container.cpp (+4/-1)
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Alexandre Abreu (community): Approve
-
Diff: 67 lines (+3/-21)2 files modifieddebian/control (+1/-3)
online-accounts-ui/main.cpp (+2/-18)
- PS Jenkins bot (community): Approve (continuous-integration)
- Timo Jyrinki (community): Approve
-
Diff: 169 lines (+17/-31)8 files modifieddebian/control (+1/-3)
online-accounts-service/main.cpp (+6/-6)
online-accounts-service/ui-proxy.cpp (+2/-0)
online-accounts-ui/main.cpp (+2/-18)
online-accounts-ui/online-accounts-ui.pro (+1/-4)
online-accounts-ui/ui-server.cpp (+2/-0)
tests/online-accounts-service/tst_ui_proxy.cpp (+2/-0)
tests/online-accounts-ui/qml/tst_AuthorizationPage.qml (+1/-0)
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu HTML5 Theme Developers: Pending requested
-
Diff: 76 lines (+5/-21)3 files modifieddebian/control (+1/-2)
src/ubuntu-html5-app-launcher/CMakeLists.txt (+0/-2)
src/ubuntu-html5-app-launcher/main.cpp (+4/-17)
summary: |
- Should not use private Qt headers + online-accounts should not use private Qt headers |
summary: |
- online-accounts should not use private Qt headers + Oxide should provide an interface to avoid webbrowser-app / online- + accounts using private Qt headers |
Changed in oxide: | |
milestone: | none → branch-1.5 |
Changed in oxide: | |
milestone: | branch-1.5 → branch-1.6 |
description: | updated |
Changed in oxide: | |
assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
Changed in oxide: | |
assignee: | Alexandre Abreu (abreu-alexandre) → nobody |
Changed in ubuntu-system-settings-online-accounts: | |
assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
Changed in ubuntu-html5-theme: | |
assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
Changed in webbrowser-app: | |
assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
Changed in oxide: | |
milestone: | branch-1.6 → none |
Changed in webbrowser-app: | |
assignee: | Alexandre Abreu (abreu-alexandre) → Olivier Tilloy (osomon) |
status: | Confirmed → In Progress |
Changed in webbrowser-app (Ubuntu): | |
status: | Confirmed → In Progress |
assignee: | nobody → Olivier Tilloy (osomon) |
Changed in ubuntu-html5-theme: | |
status: | Confirmed → In Progress |
Changed in ubuntu-system-settings-online-accounts: | |
status: | Confirmed → In Progress |
Changed in webbrowser-app: | |
importance: | Undecided → Medium |
Changed in webbrowser-app: | |
status: | In Progress → Fix Released |
Changed in ubuntu-system-settings-online-accounts: | |
status: | In Progress → Fix Released |
no longer affects: | oxide-qt (Ubuntu) |
no longer affects: | oxide |
Changed in ubuntu-system-settings-online-accounts: | |
assignee: | Alexandre Abreu (abreu-alexandre) → Alberto Mardegan (mardy) |
status: | Fix Released → In Progress |
Changed in ubuntu-html5-theme: | |
importance: | Undecided → High |
Changed in ubuntu-html5-theme: | |
status: | In Progress → Fix Committed |
Changed in ubuntu-html5-theme: | |
status: | Fix Committed → Fix Released |
Changed in ubuntu-system-settings-online-accounts: | |
status: | In Progress → Fix Released |
+1 this feels like unnecessary technical details, which could be hidden behind an interface or configuration option.