[browser] visuals for multi-select mode in history view need update
Bug #1412732 reported by
Olivier Tilloy
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UX |
Fix Released
|
Medium
|
James Mulholland | ||
webbrowser-app |
Fix Released
|
Low
|
Riccardo Padovani | ||
webbrowser-app (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
webbrowser-app (Ubuntu RTM) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Multi-select mode in the history view was implemented as part of bug #1351167.
But the visuals do not match the visual spec exactly.
Screenshot: https:/
In particular, padding and spacing need to be adjusted. The buttons at the top should have a label, too.
[UX Comment]
All appears correct other than a cancel icon ("X") being shown for cancel instead of the back icon ("<")
Related branches
lp:~rpadovani/webbrowser-app/fixBookmarkDesign
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Olivier Tilloy: Approve
-
Diff: 239 lines (+102/-66)3 files modifiedsrc/app/webbrowser/HistorySectionDelegate.qml (+3/-1)
src/app/webbrowser/HistoryView.qml (+98/-64)
src/app/webbrowser/upstreamcomponents/ListItemWithActions.qml (+1/-1)
lp:~osomon/webbrowser-app/multi-select-close-icon
- PS Jenkins bot: Approve (continuous-integration)
- Riccardo Padovani (community): Approve
- Ubuntu Phablet Team: Pending requested
-
Diff: 12 lines (+1/-1)1 file modifiedsrc/app/webbrowser/HistoryView.qml (+1/-1)
Changed in ubuntu-ux: | |
assignee: | nobody → Giorgio Venturi (giorgio-venturi) |
importance: | Undecided → Medium |
status: | New → Fix Committed |
Changed in webbrowser-app: | |
status: | Triaged → In Progress |
assignee: | nobody → Riccardo Padovani (rpadovani) |
Changed in webbrowser-app (Ubuntu): | |
status: | New → Confirmed |
summary: |
- visuals for multi-select mode in history view need update + [browser] visuals for multi-select mode in history view need update |
Changed in webbrowser-app (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in webbrowser-app (Ubuntu RTM): | |
status: | New → Confirmed |
Changed in webbrowser-app: | |
status: | In Progress → Fix Released |
Changed in ubuntu-ux: | |
assignee: | Giorgio Venturi (giorgio-venturi) → James Mulholland (jamesjosephmulholland) |
Changed in webbrowser-app (Ubuntu RTM): | |
status: | Confirmed → Fix Released |
description: | updated |
description: | updated |
Changed in ubuntu-ux: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package webbrowser-app - 0.23+15. 04.20150224- 0ubuntu1
--------------- 04.20150224- 0ubuntu1) vivid; urgency=medium
webbrowser-app (0.23+15.
[ Olivier Tilloy ] ShareOpenGLCont exts when building with Qt >= 5.4. (LP:
* Fix a flaky autopilot test. (LP: #1423115)
* Use Qt::AA_
#1387537)
[ Riccardo Padovani ]
* Fixed design of multiselection in history view (LP: #1412732)
-- CI Train Bot <email address hidden> Tue, 24 Feb 2015 10:30:59 +0000