When there are no actions defined, the action bar should not be created
Bug #1455622 reported by
Alexandre Abreu
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu HTML5 UI SDK |
Fix Released
|
Medium
|
Unassigned | ||
| ubuntu-html5-theme (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
When there are no actions defined, the action bar should not be created. When it is it creates a white space (padding 8px) at the right of the header bar.
Related branches
lp:~abreu-alexandre/ubuntu-html5-theme/fix-page-actions
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu HTML5 Theme Developers: Pending requested
-
Diff: 425 lines (+221/-45)7 files modified0.1/ambiance/js/core.js (+37/-21)
0.1/ambiance/js/tabs.js (+10/-8)
tests/autopilot/ubuntu_html5_ui_toolkit/tests/__init__.py (+2/-1)
tests/autopilot/ubuntu_html5_ui_toolkit/tests/test_page_actions.py (+46/-0)
tests/autopilot/ubuntu_html5_ui_toolkit/tests/test_tabs.py (+2/-5)
tests/data/html/apps/rss-reader/index.html (+7/-10)
tests/data/html/test-page-actions.html (+117/-0)
| Changed in ubuntu-html5-theme: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-html5-theme (Ubuntu): | |
| status: | New → Fix Released |
| Changed in ubuntu-html5-theme: | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-html5-theme - 0.1.2+15.
---------------
ubuntu-html5-theme (0.1.2+
[ Alexandre Abreu ]
* Fix gallery & component showcase (LP: #1450614)
* Fix page actions; no need to create actions when none is defined
(LP: #1455622)
* Update debian/control to remove qt private package deps; Rely on Qt
5.4's new API (LP: #1387537)
[ CI Train Bot ]
* New rebuild forced.
[ David Barth ]
* Add a command line tool to maintain a theme installation in an html5
project (LP: #1451937)
-- CI Train Bot <email address hidden> Wed, 20 May 2015 16:51:40 +0000