Comment 0 for bug 1541025

Revision history for this message
Paweł Stołowski (stolowski) wrote :

Some scopes are still not updated to correctly handle the change in search semantics (to be released with support for filters), that is to allow searching inside departments (rather than doing search "globally", and only allow departments to be browsed).

This bug is to track any remaining scopes that needs updating.

Long explanation:

The change is in the semantics of the search in the UI. In the
ld designs search was designed to be "global", i.e. if you
start typing, departments menu disappear and the search is
"broad". Departments were meant to be used and displayed only
for browsing, i.e. when search query is empty and departments
navigation is used. This search semantics is partially
reflected in the search logic of some scopes.

In the new approach unity shell plugin will no longer reset
current department to "root" nor hide departments menu when
you start typing a query, meaning you can search inside
departments. Some scopes may not expect this and have a simple
search logic along these lines (pseudo-code for better
clarity):

if (search_query_not_empty) {
         do_global_search(query_string); // current department surely must be root , so don't bother passing it around to search! Also, don't bother creating departments menu since UI will not display it when searching
         } else { // empty search string
             display_departments_menu(); // ok, empty search, so create departments menu
             display_results_for_department(current_department);
         }