Ubuntu GNOME

  1. Bug #1163501
  2. Comment #65

Comment 65 for bug 1163501

Revision history for this message
In , Dan Winship (danw-gnome) wrote :

Comment on attachment 229268
Patch for the crash

> long /*int*/ originalAuth = WebKitGTK.soup_session_get_feature (session, WebKitGTK.webkit_soup_auth_dialog_get_type ());
>- WebKitGTK.soup_session_feature_detach (originalAuth, session);
>+ if (originalAuth != 0) {
>+ WebKitGTK.soup_session_feature_detach (originalAuth, session);
>+ }
> OS.g_signal_connect (session, WebKitGTK.authenticate, Proc5.getAddress (), webView);
>- WebKitGTK.soup_session_feature_attach (originalAuth, session);
>+ if (originalAuth != 0) {
>+ WebKitGTK.soup_session_feature_attach (originalAuth, session);
>+ }

FWIW, the lookup/detach/attach code there is completely unnecessary anyway... The only line here that actually does anything is the g_signal_connect() line.