Move unlock button to a header action
Bug #1386254 reported by
David Planella
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu File Manager App |
Fix Released
|
Medium
|
Arto Jalkanen |
Bug Description
In order to gain some precious vertical real state, unclutter the UI and not to permanently show an option that most users will not make use of (*), I would propose to move the "Unlock full access" button to be an action on the header.
(*) I believe even power users, when they use the file manager, rarely need to pick files that are outside of the unlocked MTP directories. And in any case, when they need to, revealing the action is just one tap away.
Related branches
lp:~ajalkane/ubuntu-filemanager-app/unlock-to-header
- David Planella: Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 78 lines (+26/-24)2 files modifiedsrc/app/qml/ui/AuthenticationDialog.qml (+1/-1)
src/app/qml/ui/FolderListPage.qml (+25/-23)
description: | updated |
Changed in ubuntu-filemanager-app: | |
assignee: | nobody → Arto Jalkanen (ajalkane) |
Changed in ubuntu-filemanager-app: | |
status: | Triaged → In Progress |
Changed in ubuntu-filemanager-app: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I had a comment on the original merge request on this:
I'm not sure if this is the best course of action. The problem with the header is that it is icon only. An icon in the header depicting "lock" doesn't really tell user much. I'm afraid that many a users are just puzzled and wondering "where are my files".
So for that reason I'd propose keeping the "Unlock all files" button "in your face" as it is currently. I feel the logical place where user discovers the unlock button is where the files are residing and where he is looking puzzled wondering where's the missing files.
On phone this does not need to be a problem as the action does not fit into header, but will be in additional actions which have explaining text. But I'd imagine for example on tablet where there is more space in the header, the actions might fit into the header as icons and there is no explanation text for unlocking.
But it's an easy change if you still feel this is the best course to take. You're probably right that it may be relatively seldom used feature.