Comment 3 for bug 1682388

Revision history for this message
zhanggang (gangzh) wrote :

TroveExtensionMiddleware.__init__() and ExtensionMiddleware.__init__() almost has the same code except the difference below:
ExtensionMiddleware:
        for resource_ext in ext_mgr.get_resources():
            LOG.debug('Extended resource: %s', resource_ext.collection)
            controller_resource = wsgi.Resource(resource_ext.controller,
                                                resource_ext.deserializer,
                                                resource_ext.serializer)

TroveExtensionMiddleware:
        for resource_ext in ext_mgr.get_resources():
            LOG.debug('Extended resource: %s', resource_ext.collection)
            exception_map = None
            if hasattr(resource_ext.controller, 'exception_map'):
                exception_map = resource_ext.controller.exception_map
            controller_resource = wsgi.Resource(resource_ext.controller,
                                                resource_ext.deserializer,
                                                resource_ext.serializer,
                                                exception_map)

and I find comments"The only difference here is that we are using our common.wsgi.Resource instead of the openstack common wsgi.Resource" in TRoveExtensionMiddleware.__init__().

It seems reasonable that use super(ExtensionMiddleware, self) in TroveExtensinMiddleware.__init__().

I'm not sure, can anyone confirm it?