Wrong first argument given to super in trove/common/extensions.py

Bug #1682388 reported by zhanggang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
In Progress
Medium
zhanggang

Bug Description

trove/common/extensions.py
class TroveExtensionMiddleware(ExtensionMiddleware):

In TroveExtensionMiddleware.__init__.py
    super(ExtensionMiddleware, self).__init__(application) use wrong first argument.
It should be super(TroveExtensionMiddleware, self).__init__(application)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/456542

Changed in trove:
assignee: nobody → zhanggang (gangzh)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on trove (master)

Change abandoned by zhanggang (<email address hidden>) on branch: master
Review: https://review.openstack.org/456542

Revision history for this message
zhanggang (gangzh) wrote :

TroveExtensionMiddleware.__init__() and ExtensionMiddleware.__init__() almost has the same code except the difference below:
ExtensionMiddleware:
        for resource_ext in ext_mgr.get_resources():
            LOG.debug('Extended resource: %s', resource_ext.collection)
            controller_resource = wsgi.Resource(resource_ext.controller,
                                                resource_ext.deserializer,
                                                resource_ext.serializer)

TroveExtensionMiddleware:
        for resource_ext in ext_mgr.get_resources():
            LOG.debug('Extended resource: %s', resource_ext.collection)
            exception_map = None
            if hasattr(resource_ext.controller, 'exception_map'):
                exception_map = resource_ext.controller.exception_map
            controller_resource = wsgi.Resource(resource_ext.controller,
                                                resource_ext.deserializer,
                                                resource_ext.serializer,
                                                exception_map)

and I find comments"The only difference here is that we are using our common.wsgi.Resource instead of the openstack common wsgi.Resource" in TRoveExtensionMiddleware.__init__().

It seems reasonable that use super(ExtensionMiddleware, self) in TroveExtensinMiddleware.__init__().

I'm not sure, can anyone confirm it?

Changed in trove:
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.