Comment 5 for bug 1799786

Reviewed: https://review.openstack.org/613173
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=8d889af7d44524badef765af8390cdc31febe56f
Submitter: Zuul
Branch: master

commit 8d889af7d44524badef765af8390cdc31febe56f
Author: Alex Schultz <email address hidden>
Date: Thu Oct 25 10:13:42 2018 -0600

    Update functions to fix unit tests

    With the release of 5.5.7, some of the legacy function definitions no
    longer pass in unit tests. This change updates the functions that are
    failing in the tests to the modern style (4.x) for function
    declarations. Additionally we're removing teh lookup_hiera_hash
    function which is failing but not actually consumed by our code base.

    There will be a followup patch to migrate the rest of the parser
    functions to the new format, but this patch should unblock the gates.

    NOTE: git thinks some of these files have been added/deleted rather than
    git move due to the large amount of changes between the two versions of
    the file.

    Change-Id: Ie7316fd422bd4a5eb91f94016977e5d8d76c27bc
    Closes-Bug: #1799786