puppet-openstack-unit-5.5-centos-7 broken due to updated puppet 5.5.7

Bug #1799786 reported by Alex Schultz on 2018-10-24
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Critical
Alex Schultz

Bug Description

Some legacy custom functions appear to be broken in the latest 5.5.7 release of Puppet.

http://logs.openstack.org/19/611919/4/check/puppet-openstack-unit-5.5-centos-7/eab07ad/job-output.txt.gz#_2018-10-24_16_33_42_017343

2018-10-24 16:33:42.017343 | centos-7 | 1) tripleo::keepalived on centos-7-x86_64 behaves like tripleo::keeplived with redis virtual ipv4 should contain Keepalived::Instance[53] with interface => "br-foo", virtual_ips => ["10.1.1.1/32 dev br-foo"], state => "MASTER", track_script => ["haproxy"] and priority => 101
2018-10-24 16:33:42.017367 | centos-7 | Failure/Error:
2018-10-24 16:33:42.017424 | centos-7 | is_expected.to contain_keepalived__instance('53').with(
2018-10-24 16:33:42.017454 | centos-7 | :interface => 'br-foo',
2018-10-24 16:33:42.017506 | centos-7 | :virtual_ips => [ "#{params[:redis_virtual_ip]}/32 dev br-foo" ],
2018-10-24 16:33:42.017536 | centos-7 | :state => 'MASTER',
2018-10-24 16:33:42.017568 | centos-7 | :track_script => ['haproxy'],
2018-10-24 16:33:42.017596 | centos-7 | :priority => 101
2018-10-24 16:33:42.017612 | centos-7 | )
2018-10-24 16:33:42.017624 | centos-7 |
2018-10-24 16:33:42.017767 | centos-7 | expected that the catalogue would contain Keepalived::Instance[53] with interface set to "br-foo" but it is set to "", and parameter virtual_ips set to ["10.1.1.1/32 dev br-foo"] but it is set to ["10.1.1.1/32 dev "]
2018-10-24 16:33:42.017791 | centos-7 | Diff:
2018-10-24 16:33:42.017803 | centos-7 |
2018-10-24 16:33:42.017827 | centos-7 | @@ -1,4 +1,4 @@
2018-10-24 16:33:42.017847 | centos-7 | -br-foo
2018-10-24 16:33:42.017863 | centos-7 |
2018-10-24 16:33:42.017904 | centos-7 | -10.1.1.1/32 dev br-foo
2018-10-24 16:33:42.017921 | centos-7 | +
2018-10-24 16:33:42.017947 | centos-7 | +10.1.1.1/32 dev
2018-10-24 16:33:42.018030 | centos-7 | Shared Example Group: "tripleo::keeplived" called from ./spec/classes/tripleo_keepalive_spec.rb:206
2018-10-24 16:33:42.018111 | centos-7 | # ./spec/classes/tripleo_keepalive_spec.rb:92:in `block (4 levels) in <top (required)>'
2018-10-24 16:33:42.018128 | centos-7 |

2018-10-24 16:33:42.027722 | centos-7 | 11) ip_to_erl_format should run ip_to_erl_format("192.168.2.1") and return "{192,168,2,1}"
2018-10-24 16:33:42.027784 | centos-7 | Failure/Error: it { should run.with_params('192.168.2.1').and_return('{192,168,2,1}') }
2018-10-24 16:33:42.027934 | centos-7 | expected ip_to_erl_format("192.168.2.1") to have returned "{192,168,2,1}" instead of raising NoMethodError(undefined method `function_ip_to_erl_format' for {}:Hash)
2018-10-24 16:33:42.028015 | centos-7 | # ./spec/functions/ip_to_erl_format_spec.rb:5:in `block (2 levels) in <top (required)>'
2018-10-24 16:33:42.028028 | centos-7 |

2018-10-24 16:33:42.030147 | centos-7 | 17) is_ip_addresses should run is_ip_addresses("192.168.2.1") and return true
2018-10-24 16:33:42.030238 | centos-7 | Failure/Error: it { should run.with_params('192.168.2.1').and_return(true) }
2018-10-24 16:33:42.030367 | centos-7 | expected is_ip_addresses("192.168.2.1") to have returned true instead of raising NoMethodError(undefined method `function_is_ip_addresses' for {}:Hash)
2018-10-24 16:33:42.030434 | centos-7 | # ./spec/functions/is_ip_addresses_spec.rb:5:in `block (2 levels) in <top (required)>'
2018-10-24 16:33:42.030448 | centos-7 |

2018-10-24 16:33:42.032913 | centos-7 | 24) lookup_hiera_hash should run lookup_hiera_hash("my_hash", "network") and return "127.0.0.1"
2018-10-24 16:33:42.032984 | centos-7 | Failure/Error: it { should run.with_params('my_hash', 'network').and_return('127.0.0.1') }
2018-10-24 16:33:42.033113 | centos-7 | expected lookup_hiera_hash("my_hash", "network") to have returned "127.0.0.1" instead of raising NoMethodError(undefined method `function_lookup_hiera_hash' for {}:Hash)
2018-10-24 16:33:42.033186 | centos-7 | # ./spec/functions/lookup_hiera_hash_spec.rb:8:in `block (2 levels) in <top (required)>'
2018-10-24 16:33:42.033200 | centos-7 |

2018-10-24 16:33:42.035580 | centos-7 | 31) netmask_to_cidr should run netmask_to_cidr("255.255.255.0") and return 24
2018-10-24 16:33:42.035642 | centos-7 | Failure/Error: it { should run.with_params('255.255.255.0').and_return(24) }
2018-10-24 16:33:42.035748 | centos-7 | expected netmask_to_cidr("255.255.255.0") to have returned 24 instead of raising NoMethodError(undefined method `function_netmask_to_cidr' for {}:Hash)
2018-10-24 16:33:42.035827 | centos-7 | # ./spec/functions/netmask_to_cidr_spec.rb:5:in `block (2 levels) in <top (required)>'
2018-10-24 16:33:42.035841 | centos-7 |

Changed in tripleo:
status: Triaged → In Progress

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: master
Review: https://review.openstack.org/613173
Reason: clearing up the gate to free up resources.

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: master
Review: https://review.openstack.org/613411
Reason: clearing up the gate to free up resources.

Changed in tripleo:
assignee: Alex Schultz (alex-schultz) → Bogdan Dobrelya (bogdando)
Changed in tripleo:
assignee: Bogdan Dobrelya (bogdando) → Alex Schultz (alex-schultz)

Reviewed: https://review.openstack.org/613173
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=8d889af7d44524badef765af8390cdc31febe56f
Submitter: Zuul
Branch: master

commit 8d889af7d44524badef765af8390cdc31febe56f
Author: Alex Schultz <email address hidden>
Date: Thu Oct 25 10:13:42 2018 -0600

    Update functions to fix unit tests

    With the release of 5.5.7, some of the legacy function definitions no
    longer pass in unit tests. This change updates the functions that are
    failing in the tests to the modern style (4.x) for function
    declarations. Additionally we're removing teh lookup_hiera_hash
    function which is failing but not actually consumed by our code base.

    There will be a followup patch to migrate the rest of the parser
    functions to the new format, but this patch should unblock the gates.

    NOTE: git thinks some of these files have been added/deleted rather than
    git move due to the large amount of changes between the two versions of
    the file.

    Change-Id: Ie7316fd422bd4a5eb91f94016977e5d8d76c27bc
    Closes-Bug: #1799786

Changed in tripleo:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/613411
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=4a576293c1e8edc73008b3a344445aa97ac66dad
Submitter: Zuul
Branch: master

commit 4a576293c1e8edc73008b3a344445aa97ac66dad
Author: Alex Schultz <email address hidden>
Date: Thu Oct 25 14:16:34 2018 -0600

    Update parser functions to 4.x api

    This change updates additional parser functions we have to use teh
    puppet 4.x function api. This includes some basic unit tests to ensure
    they continue to function as expected.

    Change-Id: Iebeb82b2890216bed139219441718fffc4004391
    Related-Bug: #1799786

This issue was fixed in the openstack/puppet-tripleo 10.2.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers