Comment 3 for bug 1659560

Thanks for this Michael, from a quick look at the patches, it seems there's more to it than your initial description:

1. puppet-tripleo profiles for contrail services needed refactoring to reduce coupling and enable deployment via composable services on some custom roles

2. Related refactoring in t-h-t to enable the composable service templates to be placed somewhere other than the controller role.

3. Define a series of custom roles, with some customizations to the base role definitions (it's not using the generic puppet/role.role.j2.yaml, which is what we normally expect with custom roles)

The two patches as posted are pretty large, so we may look at splitting them up a bit for easier reviews/testing, and also I'd like to see if we can reduce the level of customization needed in t-h-t so the custom roles conform more closely to our normal definition.

Overall though this very impressive work, I'm glad to see the integration here has been progressing well, we just need to figure out the cleanest way to support these changes in the upstream trees.