Contrail services assigned to wrong roles

[Michael Henkel]

Some of the Contrail services are assigned to the wrong roles which leads to issues as an impact on analytics can impact the control plane. Services must be re-organized to the correct roles.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/425717

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/425752

[Steven Hardy (shardy)]

Thanks for this Michael, from a quick look at the patches, it seems there's more to it than your initial description:

1. puppet-tripleo profiles for contrail services needed refactoring to reduce coupling and enable deployment via composable services on some custom roles

2. Related refactoring in t-h-t to enable the composable service templates to be placed somewhere other than the controller role.

3. Define a series of custom roles, with some customizations to the base role definitions (it's not using the generic puppet/role.role.j2.yaml, which is what we normally expect with custom roles)

The two patches as posted are pretty large, so we may look at splitting them up a bit for easier reviews/testing, and also I'd like to see if we can reduce the level of customization needed in t-h-t so the custom roles conform more closely to our normal definition.

Overall though this very impressive work, I'm glad to see the integration here has been progressing well, we just need to figure out the cleanest way to support these changes in the upstream trees.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Henkel (<email address hidden>) on branch: master
Review: https://review.openstack.org/425752
Reason: broken

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michael Henkel (<email address hidden>) on branch: master
Review: https://review.openstack.org/425752

[Michael Henkel (mhenkel-3)]

I proposed patch https://review.openstack.org/425975 to puppet-tripleo, but it's not been automatically linked

[Steven Hardy (shardy)]

We discussed this in the weekly TripleO meeting and it was agreed this can have a FFE for Ocata.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/425975
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=9c9667e214987fe4a41a96d13f58541f0ddd53a2
Submitter: Jenkins
Branch: master

commit 9c9667e214987fe4a41a96d13f58541f0ddd53a2
Author: Michael Henkel <email address hidden>
Date: Fri Jan 27 00:36:54 2017 +0100

    Re-organizes Contrail services to the correct roles

    In current setup some Contrail services belong to the wrong roles.
    The Contrail control plane can be impacted if the Analytics database has problems.
    Furthermore contrail tripleo puppet modules are being refactored to conform to the
    new interface of the puppet-contrail modules.

    Closes-Bug: 1659560

    Change-Id: Id0dd35b95c5fe9d0fcc1e16c4b7d6cc601f10818

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/425717
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=da91bb6e1e041b4462765c87ff36458528d952e8
Submitter: Jenkins
Branch: master

commit da91bb6e1e041b4462765c87ff36458528d952e8
Author: Michael Henkel <email address hidden>
Date: Thu Jan 26 15:24:04 2017 +0100

    Re-organizes Contrail services to the correct roles

    In current setup some Contrail services belong to the wrong roles.
    The Contrail control plane can be impacted if the Analytics database has
    problems.

    Change-Id: I0d57a2324c38b5b20cc687c6217a7a364941f7e6
    Depends-On: Id0dd35b95c5fe9d0fcc1e16c4b7d6cc601f10818
    Closes-Bug: #1659560

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 6.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Steven Hardy (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/439172