the addition to puppet-cinder at https://review.openstack.org/#/c/281851/ conflicts with our use of cinder_config in tripleo [2] because in cinder the 'host' setting has a default in its CONF [1] and that causes the puppet os_service_default fact to always set the key, even when it's not passed to the class
hi, thanks for investigating into this
the addition to puppet-cinder at https:/ /review. openstack. org/#/c/ 281851/ conflicts with our use of cinder_config in tripleo [2] because in cinder the 'host' setting has a default in its CONF [1] and that causes the puppet os_service_default fact to always set the key, even when it's not passed to the class
the change for puppet-cinder in stable/liberty at https:/ /review. openstack. org/#/c/ 281998/ mimic the same behaviour using $::hostname
the change at https:/ /review. openstack. org/#/c/ 281858/ should fix this, but it should have landed before the puppet change and not depend on it :(
1. https:/ /github. com/openstack/ cinder/ blob/master/ cinder/ common/ config. py#L127 /github. com/openstack/ tripleo- heat-templates/ blob/master/ puppet/ hieradata/ controller. yaml#L101
2. https:/