Error: Duplicate declaration: Cinder_config[DEFAULT/host] is already declared in file /etc/puppet/modules/cinder/manifests/init.pp:419

[James Slagle]

Most (if not all) tripleo-ci jobs on master are failing with:

2016-02-18 23:32:58.294 | "deploy_stderr": "\u001b[1;31mWarning: Variable access via 'notification_email_to' is deprecated. Use '@notification_email_to' instead. template[/etc/puppet/modules/keepalived/templates/global_config.erb]:3\n (at /etc/puppet/modules/keepalived/templates/global_config.erb:3:in `block in result')\u001b[0m\n\u001b[1;31mWarning: notify is a metaparam; this value will inherit to all contained resources in the keepalived::instance definition\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Mongodb::Server]): Replset specified, but no replset_members or replset_config provided.\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Swift]): swift_hash_suffix has been deprecated and should be replaced with swift_hash_path_suffix, this will be removed as part of the N-cycle\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Nova::Api]): ec2_listen_port, ec2_workers and keystone_ec2_url are deprecated and have no effect. Deploy openstack/ec2-api instead.\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Nova::Network::Neutron]): neutron_admin_password is deprecated. Use neutron_password\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Nova::Network::Neutron]): neutron_admin_tenant_name is deprecated. Use neutron_tenant_name\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Nova::Network::Neutron]): neutron_admin_username is deprecated. Use neutron_username\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Nova::Network::Neutron]): neutron_admin_auth_url is deprecated. Use neutron_auth_url\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Nova::Vncproxy::Common]): Could not look up qualified variable '::nova::compute::vncproxy_host'; class ::nova::compute has not been evaluated\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Nova::Vncproxy::Common]): Could not look up qualified variable '::nova::compute::vncproxy_protocol'; class ::nova::compute has not been evaluated\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Nova::Vncproxy::Common]): Could not look up qualified variable '::nova::compute::vncproxy_port'; class ::nova::compute has not been evaluated\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Nova::Vncproxy::Common]): Could not look up qualified variable '::nova::compute::vncproxy_path'; class ::nova::compute has not been evaluated\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Neutron::Server]): identity_uri, auth_tenant, auth_user, auth_password, auth_region configuration options are deprecated in favor of auth_plugin and related options\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Neutron::Agents::L3]): parameter external_network_bridge is deprecated\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Neutron::Agents::L3]): parameter router_delete_namespaces was removed in Mitaka, it does not take any affect\u001b[0m\n\u001b[1;31mWarning: Scope(Class[Neutron::Agents::Dhcp]): The dhcp_delete_namespaces parameter was removed in Mitaka, it does not take any affect\u001b[0m\n/etc/puppet/modules/vswitch/lib/puppet/provider/vs_port/ovs.rb:3: warning: already initialized constant UUID_RE\n/etc/puppet/modules/vswitch/lib/puppet/provider/vs_port/ovs.rb:3: warning: previous definition of UUID_RE was here\n\u001b[1;31mError: Duplicate declaration: Cinder_config[DEFAULT/host] is already declared in file /etc/puppet/modules/cinder/manifests/init.pp:419; cannot redeclare at /etc/puppet/modules/cinder/manifests/config.pp:38 on node overcloud-controller-0.localdomain\u001b[0m\n\u001b[1;31mError: Duplicate declaration: Cinder_config[DEFAULT/host] is already declared in file /etc/puppet/modules/cinder/manifests/init.pp:419; cannot redeclare at /etc/puppet/modules/cinder/manifests/config.pp:38 on node overcloud-controller-0.localdomain\u001b[0m\n",

Example failed job:
http://logs.openstack.org/88/281988/5/check-tripleo/gate-tripleo-ci-f22-nonha/18e5a9b/

[James Slagle (james-slagle)]

I believe caused by this patch, https://review.openstack.org/#/c/281851/

I've proposed a revert, https://review.openstack.org/#/c/282098/

[James Slagle (james-slagle)]

Perhaps this is another possible fix? https://review.openstack.org/#/c/281858/

If so we could land that, and not have to do the revert.

[Giulio Fidente (gfidente)]

hi, thanks for investigating into this

the addition to puppet-cinder at https://review.openstack.org/#/c/281851/ conflicts with our use of cinder_config in tripleo [2] because in cinder the 'host' setting has a default in its CONF [1] and that causes the puppet os_service_default fact to always set the key, even when it's not passed to the class

the change for puppet-cinder in stable/liberty at https://review.openstack.org/#/c/281998/ mimic the same behaviour using $::hostname

the change at https://review.openstack.org/#/c/281858/ should fix this, but it should have landed before the puppet change and not depend on it :(

1. https://github.com/openstack/cinder/blob/master/cinder/common/config.py#L127
2. https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/hieradata/controller.yaml#L101