Comment 1 for bug 1849568

Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :

It's the set_current_page() in terminal.py's ensure_visible_and_focussed() that changes the selected tab. It's called not just for the last tab, but for all of them, in order.

It's in turn called from terminator.py's layout_done(), with comments like

    # For windows with a notebook

    # Cycle through pages by number

    # Set the notebook entry, then ensure Terminal is visible and focussed

so it wants to focus all the tabs.

This layout_done(), in turn, is called from ipc.py.

So we should now understand what the intent was behind focusing all the terminals (e.g. whether it can just be removed from there without side effects, or if layout_done() should take a boolean parameter whether to focus, or somehow pass the list of newly created stuff to focus, or what).