All windows switch focus to last tab upon executing terminator process

Bug #1849568 reported by Ari Fogel on 2019-10-23
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Terminator
Undecided
Unassigned

Bug Description

Version 1.91-1
Ubuntu 18.04

All terminator windows that have multiple tabs will switch the active tab to the rightmost one whenever a new terminator process is launched.

To reproduce:
1. Open one or more terminator windows
2. In each open terminator window, add one or more additional tabs
3. In each open terminator window, activate any tab other than the rightmost.
4. Launch a terminator process from any shell or via e.g. xbindkeys. Arguments to terminator do not appear to matter.

Result: A new terminator window is opened, and every open terminator window suddenly activates the rightmost tab.

Expected Result: A new terminator window is opened, but existing terminator windows should be unaffected.

Egmont Koblinger (egmont-gmail) wrote :

It's the set_current_page() in terminal.py's ensure_visible_and_focussed() that changes the selected tab. It's called not just for the last tab, but for all of them, in order.

It's in turn called from terminator.py's layout_done(), with comments like

    # For windows with a notebook

    # Cycle through pages by number

    # Set the notebook entry, then ensure Terminal is visible and focussed

so it wants to focus all the tabs.

This layout_done(), in turn, is called from ipc.py.

So we should now understand what the intent was behind focusing all the terminals (e.g. whether it can just be removed from there without side effects, or if layout_done() should take a boolean parameter whether to focus, or somehow pass the list of newly created stuff to focus, or what).

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers