Comment 4 for bug 1930782

Reviewed: https://review.opendev.org/c/openstack/tacker/+/810099
Committed: https://opendev.org/openstack/tacker/commit/fa73e438cc4f3e5edb795f70b0e1960b0edd8439
Submitter: "Zuul (22348)"
Branch: stable/xena

commit fa73e438cc4f3e5edb795f70b0e1960b0edd8439
Author: Yi Feng <email address hidden>
Date: Mon Jun 7 12:31:17 2021 +0900

    Modify processing of _heal_grant and _scale_grant

    In NFV-SOL003 V2.6.1, the add_resources'id in grant should be
    same as the vnfc_resource_info'id. However, at present, if
    you execute heal_grant and scale_grant request, the add_resources's
    resource_definition_id in grantResponse cannot match the
    vnfc_resource_info.id.

    In _scale_grant, to fix this bug, we changed the processing
    of _scale_grant in openstack._get_grant_resource_scale_out method.
    Firstly initialize the data of vnfc_resource_info according
    to the input parameters and the vnfd file, then initialize
    the add_resources data of grant according to the
    vnfc_resource_info data. After scaling out, store the data
    in the stack into vnfc_resource_info in the
    openstack.scale_resource_update method.

    In addition, in openstack._get_grant_resource_scale_out, there is
    also a problem with the placement_constraint rule setting, which
    is also corrected in this patch.

    In _heal_grant, if heal entire vnf_instance, we initialize
    remove_resources used old vnf_instance's info, and then
    reinitialize vnf_instance's info and use them to initialize
    add_resources. If heal partial vnf_instance, we just use
    update_resources in grant.

    For instantiate, if you need to use the data obtained by
    instantiate_grant in instantiate_end, the process should
    execute the post_instantiate_vnf method before instantiate_end,
    so the vnflcm_driver._instantiate_vnf method has also been
    modified.

    Closes-Bug: #1930782
    Change-Id: I1008472f5a7104324b61a413052dc44bc84c7ade