**Scale grant**
In the processing of Scale-out, "ID (random value) of add_resources" is generated and Grant request is sent before storing into vnfc_resource info.
In the case of Instantiate, vnfc_resouce_info's ID will be generated in conductor_server, and then use the id for grant's add_resources's ID before sending Grant. While in the case of Scale, vnfc_resouce_info's ID will be generated in VnfLcmDriver after sending grant.
https://opendev.org/openstack/tacker/src/branch/master/tacker/vnfm/infra_drivers/openstack/openstack.py#L1843-L1853
for resource_name, resource in nested_hot['resources'].items():
if resource['type'] == 'OS::Nova::Server':
for i in range(size):
add_uuid = uuidutils.generate_uuid()
rsc = objects.ResourceDefinition(
id=add_uuid,
type=constants.TYPE_COMPUTE,
vdu_id=resource_name,
resource_template_id=resource_name)
add_resources.append(rsc)
uuid_list.append(add_uuid)
https://opendev.org/openstack/tacker/src/branch/master/tacker/vnfm/infra_drivers/openstack/openstack.py#L1507-L1519
for rsc in scale_resurce_list:
if rsc.resource_type == 'OS::Nova::Server':
if rsc.physical_resource_id not in vnfc_rsc_list:
rsc_info = heatclient.resource_get(
scale_rsc.physical_resource_id,
rsc.resource_name)
LOG.debug("rsc %s", rsc_info)
if 'COMPLETE' in rsc.resource_status and '\
INIT_COMPLETE' != rsc.resource_status:
vnfc_resource_info = objects.VnfcResourceInfo()
vnfc_resource_info.id =\
uuidutils.generate_uuid()
vnfc_resource_info.vdu_id = rsc.resource_name
As a result, in the processing of Scale-Out, it is not possible to obtain the correct grant.add_resource.zone_id.
vnfc_resource.id and grant.add_resources.resource_definition_id do not match.
**Heal grant**
When the request for heal_grant is executed, the ID of vnfc_resource_info will be updated and use it for add_resources'id in _heal_grant and saved in vnf_dict.
However, in post_heal_vnf after the end of Heal, the data of vnf_dict is not used at all. (ID of vnfc_resource_info has not been updated)
The data updated by heal_grant is not reflected in vnf_instance.instantiated_vnf_info.vnfc_resource_info of post_heal_vnf. So, the vnf_resource_info'id will not match the id of add_resources.
At the same time, the processing of heal_grant does not distinguish the situation of heal part and heal entire. In heal_entire, involving VL and Linkport re-add.
https://opendev.org/openstack/tacker/src/branch/master/tacker/conductor/conductor_server.py#L1274-L1299
for vnfc_resource in vnf_instantiated_info_after.vnfc_resource_info:
....
add_uuid = uuidutils.generate_uuid()
resource = objects.ResourceDefinition()
resource.id = add_uuid
resource.type = constants.TYPE_COMPUTE
resource.vdu_id = vnfc_resource.vdu_id
resource.resource_template_id = vnfc_resource.vdu_id
add_resources.append(resource)
...
vnfc_resource.id = add_uuid
vnfc_resource.compute_resource = objects.ResourceHandle()
...
vnf_dict['vnf_instantiated_info_after'] = vnf_instantiated_info_after
https://opendev.org/openstack/tacker/src/branch/master/tacker/vnfm/infra_drivers/openstack/openstack.py#L1369-L1370
def post_heal_vnf(self, context, vnf_instance, vim_connection_info,
heal_vnf_request):
"""Update resource_id for each vnfc resources
:param context: A RequestContext
:param vnf_instance: tacker.objects.VnfInstance to be healed
:vim_info: Credentials to initialize Vim connection
:heal_vnf_request: tacker.objects.HealVnfRequest object containing
parameters passed in the heal request
"""
To fix above bugs, we will change the processing of scale_grant and heal_grant.
Fix proposed to branch: master
Review: https:/