commit 7064706b2721c36c5181267f58704b9344ad4ac0
Author: Samuel Merritt <email address hidden>
Date: Tue Aug 11 10:17:20 2015 -0500
Fix 500 in versioned writes with bad Destination
When this code lived in the proxy, it was protected by an "except
HTTPException" clause in proxy.Application.handle_request(). When it
moved to middleware, it lost that, and then things like
constraints.check_name_format that raised HTTPException would cause
500s. The HTTPException would make it all the way out to catch_errors
and get translated to a 500.
This commit just wraps a couple try/excepts around the bits in
versioned writes that can raise HTTPException. I tried to make it use
wsgify so I could get that for free, but that wound up being a real
pain because env/start_response are plumbed through pretty much the
whole versioned-writes middleware.
Reviewed: https:/ /review. openstack. org/211626 /git.openstack. org/cgit/ openstack/ swift/commit/ ?id=7064706b272 1c36c5181267f58 704b9344ad4ac0
Committed: https:/
Submitter: Jenkins
Branch: master
commit 7064706b2721c36 c5181267f58704b 9344ad4ac0
Author: Samuel Merritt <email address hidden>
Date: Tue Aug 11 10:17:20 2015 -0500
Fix 500 in versioned writes with bad Destination
When this code lived in the proxy, it was protected by an "except on.handle_ request( ). When it .check_ name_format that raised HTTPException would cause
HTTPException" clause in proxy.Applicati
moved to middleware, it lost that, and then things like
constraints
500s. The HTTPException would make it all the way out to catch_errors
and get translated to a 500.
This commit just wraps a couple try/excepts around the bits in
versioned writes that can raise HTTPException. I tried to make it use
wsgify so I could get that for free, but that wound up being a real
pain because env/start_response are plumbed through pretty much the
whole versioned-writes middleware.
Closes-Bug: 1483705
Change-Id: Ife165bf709e64f 313ed07c779b219 14045e51f25