testCopyDestinationSlashProblems functional test fails

Bug #1483705 reported by Alistair Coles
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Object Storage (swift)
Fix Released
Undecided
Unassigned

Bug Description

The test.functional.tests.TestFile#testCopyDestinationSlashProblems functional test fails on my SAIO (expects a 412 response, gets a 500) since the versioned_writes middleware change landed. With help form Clay and Sam figured out that I observe the failure because I do not have container_sync middleware in proxy pipeline to left of versioned_writes.

So, it would seem that the test provokes a 412 HTTPException which versioned_writes is not catching and transforming to a Response. container_sync middleware would catch the exception IF in the pipeline, but otherwise it propagates back to catch_errors.

Details:

commit 0279411c5876f815f86065cad2c91ba464e6d91b
Merge: 4e717ea 035a411
Author: Jenkins <email address hidden>
Date: Mon Aug 10 17:37:49 2015 +0000

    Merge "versioned writes middleware"

Proxy pipeline configured:

pipeline = catch_errors healthcheck proxy-logging cache tempauth slo dlo proxy-logging proxy-server

Proxy pipeline after dynamic modification:

proxy-server: Pipeline was modified. New pipeline is "catch_errors gatekeeper healthcheck proxy-logging cache tempauth versioned_writes slo dlo proxy-logging proxy-server".

Test failures:

```
======================================================================
FAIL: testCopyDestinationSlashProblems (test.functional.tests.TestFile)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/swift/swift/test/functional/tests.py", line 1088, in testCopyDestinationSlashProblems
    self.assert_status(412)
  File "/home/swift/swift/test/functional/tests.py", line 81, in assert_status
    (self.env.conn.response.status, status_or_statuses))
AssertionError: Status returned: 500 Expected: 412
    'Status returned: 500 Expected: 412' = self._formatMessage('Status returned: 500 Expected: 412', "%s is not true" % safe_repr(False))
>> raise self.failureException('Status returned: 500 Expected: 412')

======================================================================
FAIL: testCopyDestinationSlashProblems (test.functional.tests.TestFileUTF8)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/swift/swift/test/functional/tests.py", line 1088, in testCopyDestinationSlashProblems
    self.assert_status(412)
  File "/home/swift/swift/test/functional/tests.py", line 81, in assert_status
    (self.env.conn.response.status, status_or_statuses))
AssertionError: Status returned: 500 Expected: 412
    'Status returned: 500 Expected: 412' = self._formatMessage('Status returned: 500 Expected: 412', "%s is not true" % safe_repr(False))
>> raise self.failureException('Status returned: 500 Expected: 412')

----------------------------------------------------------------------
```

proxy.error traceback:

Aug 10 23:53:05 u134 catch_errors: Error: An error occurred:
Traceback (most recent call last):
  File "/home/swift/swift/swift/common/middleware/catch_errors.py", line 41, in handle_request
    resp = self._app_call(env)
  File "/home/swift/swift/swift/common/wsgi.py", line 1033, in _app_call
    resp = self.app(env, self._start_response)
  File "/home/swift/swift/swift/common/middleware/gatekeeper.py", line 90, in __call__
    return self.app(env, gatekeeper_response)
  File "/home/swift/swift/swift/common/middleware/healthcheck.py", line 57, in __call__
    return self.app(env, start_response)
  File "/home/swift/swift/swift/common/middleware/proxy_logging.py", line 298, in __call__
    iterable = self.app(env, my_start_response)
  File "/home/swift/swift/swift/common/middleware/memcache.py", line 109, in __call__
    return self.app(env, start_response)
  File "/home/swift/swift/swift/common/middleware/tempurl.py", line 335, in __call__
    return self.app(env, start_response)
  File "/home/swift/swift/swift/common/middleware/formpost.py", line 239, in __call__
    return self.app(env, start_response)
  File "/home/swift/swift/swift/common/middleware/ratelimit.py", line 301, in __call__
    return self.app(env, start_response)
  File "/home/swift/swift/swift/common/middleware/list_endpoints.py", line 198, in __call__
    return self.app(env, start_response)
  File "/home/swift/swift/swift/common/middleware/tempauth.py", line 284, in __call__
    return self.app(env, start_response)
  File "/home/swift/swift/swift/common/middleware/staticweb.py", line 481, in __call__
    return self.app(env, start_response)
  File "/home/swift/swift/swift/common/middleware/versioned_writes.py", line 476, in __call__
    allow_versioned_writes)(env, start_response)
  File "/home/swift/swift/swift/common/middleware/versioned_writes.py", line 399, in object_request
    container_name, object_name = check_destination_header(req)
  File "/home/swift/swift/swift/common/constraints.py", line 406, in check_destination_header
    'Destination header must be of the form '
  File "/home/swift/swift/swift/common/constraints.py", line 375, in check_path_header
    body=error_msg)
HTTPException: 412 Precondition Failed (txn: tx4657dbb359dd4ee2ab113-0055c92b51)

CVE References

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (master)

Reviewed: https://review.openstack.org/211626
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=7064706b2721c36c5181267f58704b9344ad4ac0
Submitter: Jenkins
Branch: master

commit 7064706b2721c36c5181267f58704b9344ad4ac0
Author: Samuel Merritt <email address hidden>
Date: Tue Aug 11 10:17:20 2015 -0500

    Fix 500 in versioned writes with bad Destination

    When this code lived in the proxy, it was protected by an "except
    HTTPException" clause in proxy.Application.handle_request(). When it
    moved to middleware, it lost that, and then things like
    constraints.check_name_format that raised HTTPException would cause
    500s. The HTTPException would make it all the way out to catch_errors
    and get translated to a 500.

    This commit just wraps a couple try/excepts around the bits in
    versioned writes that can raise HTTPException. I tried to make it use
    wsgify so I could get that for free, but that wound up being a real
    pain because env/start_response are plumbed through pretty much the
    whole versioned-writes middleware.

    Closes-Bug: 1483705

    Change-Id: Ife165bf709e64f313ed07c779b21914045e51f25

Changed in swift:
status: New → Fix Committed
Thierry Carrez (ttx)
Changed in swift:
milestone: none → 2.4.0
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (feature/crypto)

Fix proposed to branch: feature/crypto
Review: https://review.openstack.org/219775

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (feature/crypto)
Download full text (43.3 KiB)

Reviewed: https://review.openstack.org/219775
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=257e468e9bfd1088040419ad408106ac3c77b531
Submitter: Jenkins
Branch: feature/crypto

commit e02609c66a804845672413b06830b87395afef31
Author: Samuel Merritt <email address hidden>
Date: Tue Sep 1 15:19:50 2015 -0700

    Preserve traceback in swift-dispersion-report

    Commit c690bcb fixed a bug in the dispersion report, but changed this
    from a bare "raise" to "raise err", which loses the traceback. Not a
    big deal, but worth putting back IMO.

    Change-Id: Id5b72153a4b8df8e3faaf1fa3fb2040e28ba85cc

commit d06d4ad0fd2dfe69da8008e729651264522c6c06
Author: Minwoo Bae <email address hidden>
Date: Tue Sep 1 15:08:44 2015 -0500

    Included reference in swift.obj.diskfile to enumerate the string
    used for data file paths.

    Change-Id: Ie22caa678bc00dfc43fabec7efbbb9f34490f1b5

commit 524c89b7eeff037b8a6b421888771e15f98c2da2
Author: John Dickinson <email address hidden>
Date: Fri Aug 21 13:39:41 2015 -0700

    Updated CHANGELOG, AUTHORS, and .mailmap for 2.4.0 release.

    Change-Id: Ic6301146b839c9921bb85c4f4c1e585c9ab66661

commit 05de1305a903ee4ce9c8c50fde53c552d5b90d51
Author: Clay Gerrard <email address hidden>
Date: Thu Aug 27 18:35:09 2015 -0700

    Make ssync_sender send valid chunked requests

    The connect method of ssync_sender tells the remote connection that it's
    going to send a valid HTTP chunked request, but if the remote end needs
    to respond with an error of any kind sender throws HTTP right out the
    window, picks up his ball, and closes the socket down hard - much to the
    surprise of the eventlet.wsgi server who up to this point had been
    playing along quite nicely with this 'SSYNC' nonsense assuming that
    everyone here is consenting mature adults.

    If you're going to make a "Transfer-Encoding: chunked" request have the
    good decency to finish the job with a proper '0\r\n\r\n'. [1]

    N.B. It might be possible to handle an error status during the
    initialize_request phase with some sort of 100-continue support, but
    honestly it's not entirely clear to me when the server isn't going to
    close the connection if the client is still expected to send the body
    [2] - further if the error comes later during missing_check or updates
    we'll for sure want to send the chunk transfer termination line before
    we close down the socket and this way we cover both.

    1. Really, eventlet.wsgi shouldn't be so blasted brittle about this [3]
    2. https://lists.w3.org/Archives/Public/ietf-http-wg/2005AprJun/0007.html
    3. https://github.com/eventlet/eventlet/commit/c3ce3eef0b4d0dfdbfb1ec0186d4bb204fb8ecd5

    Closes-Bug #1489587
    Change-Id: Ic17c6c3075553f8cf6ef6213e62a00282f0d01cf

commit 993ee4e37af1961adba2047d5aa2eb210e423eb3
Author: nakagawamsa <email address hidden>
Date: Fri Aug 28 11:49:43 2015 +0900

    Remove duplicate X-Backend-Storage-Policy-Index key

    There is duplicate 'X-Backend-Storage-Policy-Index' dictionary key in unit.obj.test_server.py.
    One key has fixed policy index value, and another ha...

tags: added: in-feature-crypto
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (feature/hummingbird)

Fix proposed to branch: feature/hummingbird
Review: https://review.openstack.org/221410

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to swift (feature/hummingbird)
Download full text (70.7 KiB)

Reviewed: https://review.openstack.org/221410
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=eb8f1f83f1cfc63d8452bc30096fd1c145781527
Submitter: Jenkins
Branch: feature/hummingbird

commit cb683d391cb66d0f52830de16760c80fd2afedf9
Author: OpenStack Proposal Bot <email address hidden>
Date: Sat Sep 5 06:17:51 2015 +0000

    Imported Translations from Transifex

    For more information about this automatic import see:
    https://wiki.openstack.org/wiki/Translations/Infrastructure

    Change-Id: I2d92b8e34a665fb0bb4c048cfb0c59de295dfce6

commit e4542455c8a07b7981c247df8b737816062c1655
Author: Emett Speer <email address hidden>
Date: Wed Sep 2 17:18:03 2015 -0700

    [Labs] Update links to Cloud Admin Guide

    Update links to the Cloud Admin Guide after the
    RST conversion of that book altered URLs.

    Change-Id: I899f8938498b744e62887968a65e58c00ef27f1b

commit 58fcc07523978306cd3889ada73af5d9e664cf59
Author: Christian Schwede <email address hidden>
Date: Wed Sep 2 10:52:34 2015 +0000

    Test if container_sweep is executed on unmounted devices

    This change ensures that container_sweep is not run if a device is not mounted
    and mount_check is set to True.

    Change-Id: I823083c8431d9e61fd426508033ec9188503957b

commit e02609c66a804845672413b06830b87395afef31
Author: Samuel Merritt <email address hidden>
Date: Tue Sep 1 15:19:50 2015 -0700

    Preserve traceback in swift-dispersion-report

    Commit c690bcb fixed a bug in the dispersion report, but changed this
    from a bare "raise" to "raise err", which loses the traceback. Not a
    big deal, but worth putting back IMO.

    Change-Id: Id5b72153a4b8df8e3faaf1fa3fb2040e28ba85cc

commit d06d4ad0fd2dfe69da8008e729651264522c6c06
Author: Minwoo Bae <email address hidden>
Date: Tue Sep 1 15:08:44 2015 -0500

    Included reference in swift.obj.diskfile to enumerate the string
    used for data file paths.

    Change-Id: Ie22caa678bc00dfc43fabec7efbbb9f34490f1b5

commit 615c7a204b9386e05c5bab658bfe96766ad1e680
Author: Brian Cline <email address hidden>
Date: Tue Sep 1 10:51:20 2015 -0500

    Adds useful dispersion info from changelog

    Change-Id: I1a45088fc32620b02ff9a754b02ec1eb75a59d6e

commit 3b8755098a1786c5447abf158bd686293a82977c
Author: janonymous <email address hidden>
Date: Sun Aug 2 21:29:13 2015 +0530

    Replace a / b with a // b to use integer division where needed

    Change-Id: I72c81faa62786e140b0de00e3a04934bf1b5adbd

commit 524c89b7eeff037b8a6b421888771e15f98c2da2
Author: John Dickinson <email address hidden>
Date: Fri Aug 21 13:39:41 2015 -0700

    Updated CHANGELOG, AUTHORS, and .mailmap for 2.4.0 release.

    Change-Id: Ic6301146b839c9921bb85c4f4c1e585c9ab66661

commit 05de1305a903ee4ce9c8c50fde53c552d5b90d51
Author: Clay Gerrard <email address hidden>
Date: Thu Aug 27 18:35:09 2015 -0700

    Make ssync_sender send valid chunked requests

    The connect method of ssync_sender tells the remote connection that it's
    going to send a valid HTTP chunked request, but if the remote end needs
    to respond with an error of any kind sender th...

tags: added: in-feature-hummingbird
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.