Comment 4 for bug 2073607

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/926015
Committed: https://opendev.org/starlingx/distcloud/commit/f937c7dde940b4962b1b26a519dc1174bce1b7df
Submitter: "Zuul (22348)"
Branch: master

commit f937c7dde940b4962b1b26a519dc1174bce1b7df
Author: Victor Romano <email address hidden>
Date: Thu Aug 8 17:52:16 2024 -0300

    Move 'subcloud deploy create' completion message

    Previous completion message introduced in [1] was being executed even
    if the subcloud creation failed. This commit moves the message to the
    end of try/except block, so it's only executed upon actual successful
    create completion.

    Test plan:
      - PASS: Run subcloud deploy create and verify the message correctly
              appears on the /var/log/dcmanager/dcmanager.log
      - PASS: Create an immutable inventory file for a subcloud and run
              subcloud deploy create. Verify the process fails and the
              message doesn't appear on /var/log/dcmanager/dcmanager.log

    Closes-Bug: 2073607

    [1]: https://review.opendev.org/c/starlingx/distcloud/+/924510

    Change-Id: I17240dfb130fb6ef53586195454ab5f78f2e989c
    Signed-off-by: Victor Romano <email address hidden>