DC Subcloud Creation Logs: Missing 'Complete' Log Entry

[Victor Romano]

Brief Description

DC Subcloud Creation Logs: Missing 'Complete' Log Entry

We don't have a log message saying when the subcloud create task was completed. But we do have one which says that the subcloud creation has started:

Adding subcloud subcloud110 with region 56577f6f9864a92ba9ba5b36022497a.
Creating subcloud subcloud110.

Severity

<Minor: System/Feature is usable with minor issue>

Steps to Reproduce

Create subcloud

Expected Behavior

The subcloud create should be successfull and we should see logs info reporting the completing as it does when it starts the subcloud create task

Actual Behavior

There is a log message saying the subcloud create has started but we dont have one which says when it was completed.

Reproducibility

100% reproducible

System Configuration

DC

Load info (eg: 2022-03-10_20-00-07)

NA

Timestamp/Logs

no logs captured

Alarms

no alarms

Test Activity

Feature Testing

Workaround

no workaround

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/924510

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/924510
Committed: https://opendev.org/starlingx/distcloud/commit/4080461bcb41123d8b684bcd9bbb967dc46bedb9
Submitter: "Zuul (22348)"
Branch: master

commit 4080461bcb41123d8b684bcd9bbb967dc46bedb9
Author: Victor Romano <email address hidden>
Date: Fri Jul 19 10:42:16 2024 -0300

    Add 'subcloud deploy create' completion log

    This commit adds a log message at the end of 'subcloud deploy create'
    to indicate the process was completed.

    Test plan:
      - PASS: Run subcloud deploy create and verify the message correctly
              appears on the /var/log/dcmanager/dcmanager.log

    Closes-Bug: 2073607

    Change-Id: I1fa08e19e423bccab3b0dd6914ae49a278622610
    Signed-off-by: Victor Romano <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/distcloud/+/926015

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/distcloud/+/926015
Committed: https://opendev.org/starlingx/distcloud/commit/f937c7dde940b4962b1b26a519dc1174bce1b7df
Submitter: "Zuul (22348)"
Branch: master

commit f937c7dde940b4962b1b26a519dc1174bce1b7df
Author: Victor Romano <email address hidden>
Date: Thu Aug 8 17:52:16 2024 -0300

    Move 'subcloud deploy create' completion message

    Previous completion message introduced in [1] was being executed even
    if the subcloud creation failed. This commit moves the message to the
    end of try/except block, so it's only executed upon actual successful
    create completion.

    Test plan:
      - PASS: Run subcloud deploy create and verify the message correctly
              appears on the /var/log/dcmanager/dcmanager.log
      - PASS: Create an immutable inventory file for a subcloud and run
              subcloud deploy create. Verify the process fails and the
              message doesn't appear on /var/log/dcmanager/dcmanager.log

    Closes-Bug: 2073607

    [1]: https://review.opendev.org/c/starlingx/distcloud/+/924510

    Change-Id: I17240dfb130fb6ef53586195454ab5f78f2e989c
    Signed-off-by: Victor Romano <email address hidden>