StarlingX

  1. Bug #2052534
  2. Comment #6

Comment 6 for bug 2052534

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to integ (master)

Reviewed: https://review.opendev.org/c/starlingx/integ/+/908172
Committed: https://opendev.org/starlingx/integ/commit/1ac33ded8a21f148fac7f70500fe60deb98e7f2c
Submitter: "Zuul (22348)"
Branch: master

commit 1ac33ded8a21f148fac7f70500fe60deb98e7f2c
Author: Lucas Ratusznei Fonseca <email address hidden>
Date: Tue Feb 6 13:42:30 2024 -0300

    Fix DAD and gateway detection in ifupdown/ifupdown-extra, improve logs

    The scripts in ifupdown-0.8.36 and ifupdown-extra-0.32, as they are
    distributed, don't work correctly for detecting duplicate IP addresses
    and gateway reachability in the interfaces. Because of this, error
    messages are thrown in daemon.log even if error conditions don't exist.
    This commit fixes the detection logic and also improves the log logic,
    so that messages carry useful and accurate information.

    Test plan

    Systems: AIO-SX IPv4, AIO-SX IPv6

    Scenarios without error/warning conditions
    ------------------------------------------

    For these scenarios, OAM is over a regular ethernet interface, gateway
    is reachable and there are no duplicate IP addresses. Log messages
    must reflect this.

    [PASS] mgmt and cluster-host over same eth port, pxe unassigned
    [PASS] mgmt and cluster-host over same bond port, pxe unassigned
    [PASS] mgmt and cluster-host over same vlan port, pxe unassigned
    [PASS] mgmt and cluster-host over same vlan port, pxe assigned to
           base eth
    [PASS] mgmt and cluster-host over different vlan ports, pxe assigned
           to base bond

    Scenarios with error/warning conditions
    ---------------------------------------

    For these scenarios, error/warning messages must appear and reflect
    the real conditions.

    [PASS] Cable disconnected in ethernet interface
    [PASS] Cable disconnected in bonding interface
    [PASS] Duplicate address in ethernet interface
    [PASS] Duplicate address in vlan interface
    [PASS] Duplicate address in bonding interface
    [PASS] Missing gateway in ethernet interface
    [PASS] Missing gateway in vlan interface
    [PASS] Missing gateway in bonding interface

    Closes-Bug: #2052534
    Change-Id: Ie9152eff51f21bdcb8693f554eb696d63e2bab34
    Signed-off-by: Lucas Ratusznei Fonseca <email address hidden>