Scripts from ifupdown-extra package are reporting errors incorrectly

[Lucas Ratusznei Fonseca]

Brief Description
-----------------

During system boot, Linux's networking service generates error messages that create misleading diagnostics. This happens because they are not error messages, just declared as errors by the network-scripts.

It is important to identify real error messages and keep them valid.

Severity
--------
Minor

Steps to Reproduce
------------------
Boot system

Expected Behavior
------------------
No error/warning messages if there are no problem with the network interfaces

Actual Behavior
----------------
There are incorrect and misleading error/warning messages related to the interfaces

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
Any

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/integ/+/908172

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/tools/+/908174

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/root/+/908175

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/908314

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/908314
Committed: https://opendev.org/starlingx/stx-puppet/commit/f37395a61d15226b8379a1779a0b25fbdc660248
Submitter: "Zuul (22348)"
Branch: master

commit f37395a61d15226b8379a1779a0b25fbdc660248
Author: Lucas Ratusznei Fonseca <email address hidden>
Date: Wed Feb 7 02:46:28 2024 -0300

    Add log level information to messages in apply_network_config.sh

    This commit improves the log function and adds log level information
    to all log messages in apply_network_config.sh and network_ifupdown.sh.

    Test plan

    System: AIO-SX

    [PASS] Erase ifcfg-* files in /etc/network/interfaces.d/, run
           apply_network_config.sh as root, check that messages in user.log
           have the format
               <user>: <level> <script_name>: <message>

    Closes-Bug: #2052534
    Change-Id: I97ee76385211732765a2c1d8c6b85b7ec215d0e6
    Signed-off-by: Lucas Ratusznei Fonseca <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/integ/+/908172
Committed: https://opendev.org/starlingx/integ/commit/1ac33ded8a21f148fac7f70500fe60deb98e7f2c
Submitter: "Zuul (22348)"
Branch: master

commit 1ac33ded8a21f148fac7f70500fe60deb98e7f2c
Author: Lucas Ratusznei Fonseca <email address hidden>
Date: Tue Feb 6 13:42:30 2024 -0300

    Fix DAD and gateway detection in ifupdown/ifupdown-extra, improve logs

    The scripts in ifupdown-0.8.36 and ifupdown-extra-0.32, as they are
    distributed, don't work correctly for detecting duplicate IP addresses
    and gateway reachability in the interfaces. Because of this, error
    messages are thrown in daemon.log even if error conditions don't exist.
    This commit fixes the detection logic and also improves the log logic,
    so that messages carry useful and accurate information.

    Test plan

    Systems: AIO-SX IPv4, AIO-SX IPv6

    Scenarios without error/warning conditions
    ------------------------------------------

    For these scenarios, OAM is over a regular ethernet interface, gateway
    is reachable and there are no duplicate IP addresses. Log messages
    must reflect this.

    [PASS] mgmt and cluster-host over same eth port, pxe unassigned
    [PASS] mgmt and cluster-host over same bond port, pxe unassigned
    [PASS] mgmt and cluster-host over same vlan port, pxe unassigned
    [PASS] mgmt and cluster-host over same vlan port, pxe assigned to
           base eth
    [PASS] mgmt and cluster-host over different vlan ports, pxe assigned
           to base bond

    Scenarios with error/warning conditions
    ---------------------------------------

    For these scenarios, error/warning messages must appear and reflect
    the real conditions.

    [PASS] Cable disconnected in ethernet interface
    [PASS] Cable disconnected in bonding interface
    [PASS] Duplicate address in ethernet interface
    [PASS] Duplicate address in vlan interface
    [PASS] Duplicate address in bonding interface
    [PASS] Missing gateway in ethernet interface
    [PASS] Missing gateway in vlan interface
    [PASS] Missing gateway in bonding interface

    Closes-Bug: #2052534
    Change-Id: Ie9152eff51f21bdcb8693f554eb696d63e2bab34
    Signed-off-by: Lucas Ratusznei Fonseca <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/tools/+/908174
Committed: https://opendev.org/starlingx/tools/commit/74b47609a310e83f72c612ffbb4d6262fd2a9e1b
Submitter: "Zuul (22348)"
Branch: master

commit 74b47609a310e83f72c612ffbb4d6262fd2a9e1b
Author: Lucas Ratusznei Fonseca <email address hidden>
Date: Tue Feb 6 13:56:34 2024 -0300

    Add ndisc6 package to iso, allow patches on ifupdown package

    The ndisc6 package has useful diagnostic tools for IPv6 networks. It is
    being added to allow for duplicate address and gateway reachability
    detection by the scripts from the ifupdown-extra package.
    The ifupdown package is being removed from the list because it's being
    added via the integ project instead, to allow for patches.

    Test Plan

    [PASS] downloader
    [PASS] build-pkgs --clean --all
    [PASS] build-image
    [PASS] Run full build, system install, bootstrap and unlock SX system
    [PASS] Run command "dpkg --list | grep ndisc6"
    [PASS] Run command "ndisc6 --help"
    [PASS] Run command "dpkg --list | grep ifupdown"
    [PASS] Run command "ifup --help"

    Depends-On: https://review.opendev.org/c/starlingx/integ/+/908172

    Closes-Bug: #2052534
    Change-Id: I9dd38bbd1f89e266e0b55ffde9865f94a641c8ff
    Signed-off-by: Lucas Ratusznei Fonseca <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/root/+/908175
Committed: https://opendev.org/starlingx/root/commit/03f6257ffc977fcb9991af8b410a3eba6ca613ab
Submitter: "Zuul (22348)"
Branch: master

commit 03f6257ffc977fcb9991af8b410a3eba6ca613ab
Author: Lucas Ratusznei Fonseca <email address hidden>
Date: Tue Feb 6 13:57:53 2024 -0300

    Add ndisc6 package to iso

    The ndisc6 package has useful diagnostic tools for IPv6 networks. It is
    being added to allow for duplicate address and gateway reachability
    detection by the scripts from the ifupdown-extra package. This change
    is intended to work in conjunction with
    https://review.opendev.org/c/starlingx/integ/+/908172.

    Test Plan

    [PASS] downloader
    [PASS] build-pkgs --clean --all
    [PASS] build-image
    [PASS] Run full build, system install, bootstrap and unlock SX system
    [PASS] Run command "dpkg --list | grep ndisc6"
    [PASS] Run command "ndisc6 --help"

    Depends-On: https://review.opendev.org/c/starlingx/tools/+/908174
    Closes-Bug: #2052534
    Change-Id: Idc9fc352a3d3b0e2e1c3cb370c5a826cc7d33670
    Signed-off-by: Lucas Ratusznei Fonseca <email address hidden>