Comment 1 for bug 1791880

Revision history for this message
Austin Sun (sunausti) wrote :

as aligned , we don't need fix by now.

https://review.openstack.org/#/c/611323/

These code changes are incorrect.
I intemperate that the goal for these open function calls are to open device /dev/null as fd=0,1,2 (or stdin, stdout and stderr). of which, stdin is rdonly and stdout and stderr are wronly.
The FDs are meant to open for the full life cycle of the thread. It may be better to close them at the exit of the thread if it needs to, but it wouldn't become resource leak unless the thread is to restart, which is not the case.