Fix "Resource leak" issues reported by static analysis in Stx-ha

[haitao wang]

Title
-----

Fix "Resource leak" issues reported by static analysis in Stx-ha

Brief Description
-----------------

After triaging a scan report for C/C++ static code analysis, we found that there are high impact issues which need a fix. This meta bug will cover the resource leak" category in c/c++ code in Stx-ha.

Severity
--------
Provide the severity of the defect.
Major

Steps to Reproduce
------------------
Run a static analysis tool

[Austin Sun (sunausti)]

as aligned , we don't need fix by now.

https://review.openstack.org/#/c/611323/

These code changes are incorrect.
I intemperate that the goal for these open function calls are to open device /dev/null as fd=0,1,2 (or stdin, stdout and stderr). of which, stdin is rdonly and stdout and stderr are wronly.
The FDs are meant to open for the full life cycle of the thread. It may be better to close them at the exit of the thread if it needs to, but it wouldn't become resource leak unless the thread is to restart, which is not the case.

[Bruce Jones (brucej)]

Please update this bug with specific file and line number information for the static analysis issue. Make sure the bug has enough information for someone to find the problem in the code without access to the tool or the report.

[Austin Sun (sunausti)]

Fix merged in ML https://review.openstack.org/#/c/611323/