© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Hi Andy,
Thanks for the patch. Some feedback:
- Does your scanner support these options? Could you provide the output of simple-scan -d when running it? (To see what numbers your driver expects).
- You should only set the setting if it's not the default - otherwise leave it to the driver to choose
- The GUI should have sliders, not numbers (i.e. "darker ----|----- lighter")
- The selected value should be scaled to what the driver expects. e.g. a driver might have a contrast setting from 0-100, or -100 to 100. We need to see how most drivers behave. (This is why it's important not to set the value if it's not configured - 0 might be 0 contrast, or default contrast).
I'm a little worried about how consistent drivers are with these settings, but I support the patch if it works. This setting will be "advanced" as most users will adjust the brightness/contrast after the scan is completed.