Comment 2 for bug 1732744

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/520666
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=8bfcd2b0e6ff90c7a0e80af4ee14e60a71401cc3
Submitter: Zuul
Branch: master

commit 8bfcd2b0e6ff90c7a0e80af4ee14e60a71401cc3
Author: Matt Riedemann <email address hidden>
Date: Thu Nov 16 12:45:51 2017 -0500

    Remove SecretsHelper

    This code hasn't worked for over two years when
    9ed9ab68f7d2fb98c505afc3a1079a72f15c959c was added
    which does API version discovery, which requires auth,
    which happens before the SecretsHelper is used. That was
    back in the 2.27.0 release in the Liberty series.

    Given how long this has been broken without anyone noticing,
    and it's undocumented and untested (basically), and
    python-openstackclient properly handles prompting for a password,
    we should just remove this code rather than try to fix it.

    Change-Id: I62188e73a48f6878ce920a3b4724dba101564aef
    Closes-Bug: #1732744