SecretsHelper has not worked since 2015

Bug #1732744 reported by Matt Riedemann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
python-novaclient
Fix Released
Medium
Matt Riedemann

Bug Description

This change https://review.openstack.org/#/c/184281/ in 2015 (Liberty release, 2.27.0 release of novaclient) broke the SecretsHelper in the shell because it does API version discovery which requires authentication, but if you don't provide a --os-token or --os-password (or their equivalent environment variables), we don't even get to the SecretsHelper code to prompt for a password.

Moving the SecretsHelper code block up before the API version discovery does get you the password prompt, but it appears to still not work properly:

http://paste.openstack.org/show/626539/

Given how long this has been broken and no one has cared, it seems pointless to fix it at this point, and it's untested, so we should probably just remove it.

Matt Riedemann (mriedem)
Changed in python-novaclient:
status: New → Triaged
assignee: nobody → Matt Riedemann (mriedem)
Matt Riedemann (mriedem)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/520666

Changed in python-novaclient:
status: Triaged → In Progress
Matt Riedemann (mriedem)
Changed in python-novaclient:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-novaclient (master)

Reviewed: https://review.openstack.org/520666
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=8bfcd2b0e6ff90c7a0e80af4ee14e60a71401cc3
Submitter: Zuul
Branch: master

commit 8bfcd2b0e6ff90c7a0e80af4ee14e60a71401cc3
Author: Matt Riedemann <email address hidden>
Date: Thu Nov 16 12:45:51 2017 -0500

    Remove SecretsHelper

    This code hasn't worked for over two years when
    9ed9ab68f7d2fb98c505afc3a1079a72f15c959c was added
    which does API version discovery, which requires auth,
    which happens before the SecretsHelper is used. That was
    back in the 2.27.0 release in the Liberty series.

    Given how long this has been broken without anyone noticing,
    and it's undocumented and untested (basically), and
    python-openstackclient properly handles prompting for a password,
    we should just remove this code rather than try to fix it.

    Change-Id: I62188e73a48f6878ce920a3b4724dba101564aef
    Closes-Bug: #1732744

Changed in python-novaclient:
status: In Progress → Fix Released
Revision history for this message
melanie witt (melwitt) wrote :

FWIW, I noticed when this broke back when I worked at Yahoo because it was being used there. I spent some time trying to fix it to no avail, so it wasn't something that was going to be straightforward.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-novaclient 10.0.0

This issue was fixed in the openstack/python-novaclient 10.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.