Comment 2 for bug 913905

Revision history for this message
Andreas Roehler (a-roehler) wrote : Re: [Bug 913905] Re: py-up-exception remaining

Am 10.01.2012 19:20, schrieb Richard Everson:
> Hi Andreas,
>
> Sorry not to have got back to you sooner. The problem seems to be that
> with IPython the file is not listed as "<stdin>", but as, eg,
> "/Users/reverson/projects/edge/<ipython-input-2-1cebb13502c5> in
> <module>()", so the check in py-find-next-exception needs to check this.
> Here's a possible patch (against revno 772) which works for me -- I
> haven't checked the line number which the "<stdin>" check does.
>
>
> ax:Emacs/el/python-mode/$ bzr log |head
> ------------------------------------------------------------
> revno: 772
> fixes bug(s): https://launchpad.net/bugs/913905
> committer: Andreas Roehler<email address hidden>
> branch nick: python-mode
> timestamp: Tue 2012-01-10 13:48:47 +0100
> message:
> `py-up-exception' again, lp:913905
> ------------------------------------------------------------
> revno: 771
> ax:Emacs/el/python-mode/$ bzr diff -p1
> === modified file 'python-mode.el'
> --- old/python-mode.el 2012-01-10 12:48:47 +0000
> +++ new/python-mode.el 2012-01-10 18:09:23 +0000
> @@ -6110,7 +6110,8 @@
> (setq file (substring file 0 -1)))
> (when (string= errwhere "Bottom") (goto-char pos))
> (if (and file line)
> - (if (and (string= "<stdin>" file) (eq 1 line))
> + (if (or (and (string= "<stdin>" file) (eq 1 line))
> + (string-match "<ipython-input-" file))
> (error "%s of traceback" errwhere)
> (py-jump-to-exception file line py-line-number-offset))
> (error "%s of traceback" errwhere)))
>
>
> Best,
> Richard.
>

thanks, applied.

BTW there was a chunk which went only into the components branch last
commit - now present, aiming at the same.

cheers,

Andreas

>