py-up-exception remaining
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
python-mode.el |
Fix Released
|
Medium
|
Andreas Roehler |
Bug Description
Hi Andreas,
A good improvement. There's still a minor bug with IPython and moving
up the stacks with C-c -. In the demo1.py example, pressing C-c -
repeatedly goes up the stack until the
----> 1 demo1.f()
line is reached, at which point string-match says "wrong-
stringp nil"; here's the backtrace:
Debugger entered--Lisp error: (wrong-
string-
(if (string-match ".+.pyc" file) (progn (setq file ...)))
(when (string-match ".+.pyc" file) (setq file (substring file 0 -1)))
(progn (setq py-last-
(if (not (save-match-data ...)) (progn (setq py-last-
(if (save-match-data (eq ... origline)) (progn (forward-line ...) (py-find-
(if (funcall searchdir py-traceback-
(let ((orig ...) (origline ...) file line pos) (goto-char (py-point start)) (if (funcall searchdir py-traceback-
py-find-
(if (string= start "TOP") (py-find-
(if (eq direction (quote up)) (if (string= start "TOP") (py-find-
(let* ((name ...) (buffer ...)) (when buffer (set-buffer ...)) (switch-to-buffer (current-buffer)) (if (eq direction ...) (if ... ... ...) (if ... ... ...)))
py-find-
py-up-
call-
At this point the cursor in the *IPython* buffer is sitting at the start
of the "----> 1 demo1.f()" line. It's not much of a problem, because on
pressing C-c - again, the mini-buffer reports, "Top of traceback".
>> >> Secondly, the SyntaxError exceptions in the IPython buffer don't get
>> >> matched. Pressing C-c - does nothing with the following:
>> >>
>> >> In [1]: import demo2
>> >> File "demo3.py", line 4
>> >> if a != 25
>> >> ^
>> >> SyntaxError: invalid syntax
>> >>
Works well for me!
>> >> One thing that would be very useful would be to limit the searching for exception reporting lines to the *last* set of exceptions. If you have a long Python or IPython session there will probably be several exceptions and pressing C-c - repeatedly, not only goes up the stack for the last exception, but then revisits the stack for the previous one, and so on until the beginning of the buffer is reached. I don't know if it's feasible to narrow the search just to the last exception.
This too works well for me with Python, but with IPython presssing C-c -
repeatedly still goes back to previous stack traces. In case it helps,
I've attached the contents my *IPython* buffer that does this.
Thanks again.
Cheers,
Richard.
** Attachment added: "*IPython*"
https:/
-- You received this bug notification because you are subscribed to the bug report. https:/
Changed in python-mode: | |
assignee: | nobody → Andreas Roehler (a-roehler) |
milestone: | none → 6.0.5 |
importance: | Undecided → Medium |
status: | New → In Progress |
Changed in python-mode: | |
status: | In Progress → Fix Committed |
Changed in python-mode: | |
status: | Fix Committed → In Progress |
Changed in python-mode: | |
status: | In Progress → Fix Committed |
Changed in python-mode: | |
status: | Fix Committed → Fix Released |
Hi Andreas,
Sorry not to have got back to you sooner. The problem seems to be that with IPython the file is not listed as "<stdin>", but as, eg, "/Users/ reverson/ projects/ edge/<ipython- input-2- 1cebb13502c5> in <module>()", so the check in py-find- next-exception needs to check this. Here's a possible patch (against revno 772) which works for me -- I haven't checked the line number which the "<stdin>" check does.
ax:Emacs/ el/python- mode/$ bzr log |head ------- ------- ------- ------- ------- ------- ------- ---- /launchpad. net/bugs/ 913905 ------- ------- ------- ------- ------- ------- ------- ---- el/python- mode/$ bzr diff -p1
(setq file (substring file 0 -1)))
(when (string= errwhere "Bottom") (goto-char pos))
(if (and file line)
(error "%s of traceback" errwhere)
(py-jump- to-exception file line py-line- number- offset) )
(error "%s of traceback" errwhere)))
-------
revno: 772
fixes bug(s): https:/
committer: Andreas Roehler <email address hidden>
branch nick: python-mode
timestamp: Tue 2012-01-10 13:48:47 +0100
message:
`py-up-exception' again, lp:913905
-------
revno: 771
ax:Emacs/
=== modified file 'python-mode.el'
--- old/python-mode.el 2012-01-10 12:48:47 +0000
+++ new/python-mode.el 2012-01-10 18:09:23 +0000
@@ -6110,7 +6110,8 @@
- (if (and (string= "<stdin>" file) (eq 1 line))
+ (if (or (and (string= "<stdin>" file) (eq 1 line))
+ (string-match "<ipython-input-" file))
Best,
Richard.
On 10 Jan 2012, at 13:07, Andreas Roehler wrote:
> ** Changed in: python-mode /bugs.launchpad .net/bugs/ 913905 type-argument type-argument stringp nil) match(" .+.pyc" nil) exeption- buffer (current-buffer)) (if (save-match-data ...) (progn ...) (setq line ... pos ... file ...)) (when (string-match ".+.pyc" file) (setq file ...)) (when (string= errwhere "Bottom") (goto-char pos)) (if (and file line) (if ... ... ...) (error "%s of traceback" errwhere))) exeption- buffer ...) (if ... ... ...) (when ... ...) (when ... ...) (if ... ... ...)) (goto-char orig) (error "%s of traceback" errwhere)) next-exception start buffer searchdir...
> Status: In Progress => Fix Committed
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https:/
>
> Title:
> py-up-exception remaining
>
> Status in An Emacs mode for editing Python code:
> Fix Committed
>
> Bug description:
> Hi Andreas,
>
> A good improvement. There's still a minor bug with IPython and moving
> up the stacks with C-c -. In the demo1.py example, pressing C-c -
> repeatedly goes up the stack until the
>
> ----> 1 demo1.f()
>
> line is reached, at which point string-match says "wrong-
> stringp nil"; here's the backtrace:
>
> Debugger entered--Lisp error: (wrong-
> string-
> (if (string-match ".+.pyc" file) (progn (setq file ...)))
> (when (string-match ".+.pyc" file) (setq file (substring file 0 -1)))
> (progn (setq py-last-
> (if (not (save-match-data ...)) (progn (setq py-last-
> (if (save-match-data (eq ... origline)) (progn (forward-line ...) (py-find-