Comment 4 for bug 1528308

Reviewed: https://review.openstack.org/260620
Committed: https://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=def536208d70b70171a8f6b5797077b0638abde9
Submitter: Jenkins
Branch: stable/liberty

commit def536208d70b70171a8f6b5797077b0638abde9
Author: Emilien Macchi <email address hidden>
Date: Mon Dec 21 13:52:06 2015 +0100

    Manage Keystone_endpoint and Keystone_service without warnings by default

    A recent change (1] made Keystone_endpoint matching service by name/type.
    This change added a warning if endpoints were not created with a default
    service.
    The way this new feature was added is problematic because we had
    warnings by default, since all Puppet modules use this define, so it
    introduced a poor user experience.

    This patch makes sure a service type is configured with the new way in
    the keystone::resource::service_identity function, when creating
    endpoint.
    For backward compatibility, when no service type is specified, we have now a
    conditional that sends a warning if no service type is set but still
    create the endpoints.
    For the service management, it adds the service type with the new way,
    so we don't have any warning by default.

    So from this patch, we don't have this kind of warning by default:
    /Keystone_endpoint[RegionOne/keystone]/type: Support for a endpoint
    without the type set is deprecated in Liberty. It will be dropped in
    Mitaka

    [1] http://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=0a4e06abb0f5b3f324464ff5219d2885816311ce

    Closes-Bug: #1528308
    Change-Id: I6e411d8f81c7ae5c768d85a236c0942d265c74dd
    (cherry picked from commit 6e811badf0dc43b980ca3479e47a4a13eb9cad4b)