Keystone_endpoint warning everywhere by default

Bug #1528308 reported by Emilien Macchi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-keystone
Fix Released
Critical
Emilien Macchi

Bug Description

A recent change (1] made Keystone_endpoint matching service by name/type.

This change added a warning if endpoints were not created with a default service.
The way this new feature was added is problematic because we had warnings by default, since all Puppet modules use this define, so it introduced a poor user experience.

Warning present everywhere since this commit:
/Keystone_endpoint[RegionOne/keystone]/type: Support for a endpoint without the type set is deprecated in Liberty. It will be dropped in Mitaka

[1] http://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=0a4e06abb0f5b3f324464ff5219d2885816311ce

Changed in puppet-keystone:
importance: Undecided → Critical
assignee: nobody → Emilien Macchi (emilienm)
Changed in puppet-keystone:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-keystone (master)

Reviewed: https://review.openstack.org/259996
Committed: https://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=6e811badf0dc43b980ca3479e47a4a13eb9cad4b
Submitter: Jenkins
Branch: master

commit 6e811badf0dc43b980ca3479e47a4a13eb9cad4b
Author: Emilien Macchi <email address hidden>
Date: Mon Dec 21 13:52:06 2015 +0100

    Manage Keystone_endpoint and Keystone_service without warnings by default

    A recent change (1] made Keystone_endpoint matching service by name/type.
    This change added a warning if endpoints were not created with a default
    service.
    The way this new feature was added is problematic because we had
    warnings by default, since all Puppet modules use this define, so it
    introduced a poor user experience.

    This patch makes sure a service type is configured with the new way in
    the keystone::resource::service_identity function, when creating
    endpoint.
    For backward compatibility, when no service type is specified, we have now a
    conditional that sends a warning if no service type is set but still
    create the endpoints.
    For the service management, it adds the service type with the new way,
    so we don't have any warning by default.

    So from this patch, we don't have this kind of warning by default:
    /Keystone_endpoint[RegionOne/keystone]/type: Support for a endpoint
    without the type set is deprecated in Liberty. It will be dropped in
    Mitaka

    [1] http://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=0a4e06abb0f5b3f324464ff5219d2885816311ce

    Closes-Bug: #1528308
    Change-Id: I6e411d8f81c7ae5c768d85a236c0942d265c74dd

Changed in puppet-keystone:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-keystone (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/260620

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on puppet-keystone (stable/liberty)

Change abandoned by Emilien Macchi (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/260620

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-keystone (stable/liberty)

Reviewed: https://review.openstack.org/260620
Committed: https://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=def536208d70b70171a8f6b5797077b0638abde9
Submitter: Jenkins
Branch: stable/liberty

commit def536208d70b70171a8f6b5797077b0638abde9
Author: Emilien Macchi <email address hidden>
Date: Mon Dec 21 13:52:06 2015 +0100

    Manage Keystone_endpoint and Keystone_service without warnings by default

    A recent change (1] made Keystone_endpoint matching service by name/type.
    This change added a warning if endpoints were not created with a default
    service.
    The way this new feature was added is problematic because we had
    warnings by default, since all Puppet modules use this define, so it
    introduced a poor user experience.

    This patch makes sure a service type is configured with the new way in
    the keystone::resource::service_identity function, when creating
    endpoint.
    For backward compatibility, when no service type is specified, we have now a
    conditional that sends a warning if no service type is set but still
    create the endpoints.
    For the service management, it adds the service type with the new way,
    so we don't have any warning by default.

    So from this patch, we don't have this kind of warning by default:
    /Keystone_endpoint[RegionOne/keystone]/type: Support for a endpoint
    without the type set is deprecated in Liberty. It will be dropped in
    Mitaka

    [1] http://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=0a4e06abb0f5b3f324464ff5219d2885816311ce

    Closes-Bug: #1528308
    Change-Id: I6e411d8f81c7ae5c768d85a236c0942d265c74dd
    (cherry picked from commit 6e811badf0dc43b980ca3479e47a4a13eb9cad4b)

tags: added: in-stable-liberty
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-ceilometer 7.1.0

This issue was fixed in the openstack/puppet-ceilometer 7.1.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-cinder 7.1.0

This issue was fixed in the openstack/puppet-cinder 7.1.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-designate 7.1.0

This issue was fixed in the openstack/puppet-designate 7.1.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-glance 7.1.0

This issue was fixed in the openstack/puppet-glance 7.1.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-gnocchi 7.1.0

This issue was fixed in the openstack/puppet-gnocchi 7.1.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-heat 7.1.0

This issue was fixed in the openstack/puppet-heat 7.1.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-ironic 7.1.0

This issue was fixed in the openstack/puppet-ironic 7.1.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-keystone 7.1.0

This issue was fixed in the openstack/puppet-keystone 7.1.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-manila 7.1.0

This issue was fixed in the openstack/puppet-manila 7.1.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-murano 7.1.0

This issue was fixed in the openstack/puppet-murano 7.1.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-neutron 7.1.0

This issue was fixed in the openstack/puppet-neutron 7.1.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-nova 7.1.0

This issue was fixed in the openstack/puppet-nova 7.1.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-sahara 7.1.0

This issue was fixed in the openstack/puppet-sahara 7.1.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-swift 7.1.0

This issue was fixed in the openstack/puppet-swift 7.1.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-trove 7.1.0

This issue was fixed in the openstack/puppet-trove 7.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers