Comment 1 for bug 2033929

Revision history for this message
Takashi Kajinami (kajinamit) wrote :

Sorry I didn't reply to you timely. Let me leave a few comments.

> * there is no virtualenv - manually creating one is not recommended

We have the horizon::dashboard defined resource type which can be used to install dashboard plugin.
As far as I've checked all of RDO, Ubuntu and Debian provides the dashboard package so you can use the package installation instead of using virtualenv.
```
horizon::dashboard { 'ironic': }
```

One problem I'm aware now is that the package name of ironic-ui does not align with the expected package naming (it's not python3-ironic-dashboard but python3-ironic-ui). We probably have to create a specific class (like horizon::dashboard::ironic) to support Debian/Ubuntu. I'll work on this later.

> * run_tests.sh could not be found
> * npm run test fails
These are not really specific to ironic-dashboard and probably we should implement this in the base horizon class.
For now we have no mechanism to run these validations.

> * It's unclear how to run in production the dashboard with the plugin enabled.
IMO this is really out of puppet-ironic's scope and needs comment from ironic-ui side.