Manage Ironic-UI plugin installation

[Francesco Di Nucci]

Actually it is not possible to install he Ironic-UI plugin (https://opendev.org/openstack/ironic-ui) with puppet-horizon.

Manual installation [https://docs.openstack.org/ironic-ui/2023.1/install/installation.html] is troublesome.
When Horizon is installed through Puppet and plugin is manually installed:
* there is no virtualenv - manually creating one is not recommended
* run_tests.sh could not be found
* npm run test fails
* It's unclear how to run in production the dashboard with the plugin enabled.

I think it would be useful to be able to install the plugin through the Puppet module (and clarify the install instructions, but this is probably up to ironic-ui project)

[Takashi Kajinami (kajinamit)]

Sorry I didn't reply to you timely. Let me leave a few comments.

> * there is no virtualenv - manually creating one is not recommended

We have the horizon::dashboard defined resource type which can be used to install dashboard plugin.
As far as I've checked all of RDO, Ubuntu and Debian provides the dashboard package so you can use the package installation instead of using virtualenv.
```
horizon::dashboard { 'ironic': }
```

One problem I'm aware now is that the package name of ironic-ui does not align with the expected package naming (it's not python3-ironic-dashboard but python3-ironic-ui). We probably have to create a specific class (like horizon::dashboard::ironic) to support Debian/Ubuntu. I'll work on this later.

> * run_tests.sh could not be found
> * npm run test fails
These are not really specific to ironic-dashboard and probably we should implement this in the base horizon class.
For now we have no mechanism to run these validations.

> * It's unclear how to run in production the dashboard with the plugin enabled.
IMO this is really out of puppet-ironic's scope and needs comment from ironic-ui side.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/900799

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/900799
Committed: https://opendev.org/openstack/puppet-horizon/commit/1219aab8983b1ed44bd5ecab73f1190e44d48ade
Submitter: "Zuul (22348)"
Branch: master

commit 1219aab8983b1ed44bd5ecab73f1190e44d48ade
Author: Takashi Kajinami <email address hidden>
Date: Mon Nov 13 23:13:18 2023 +0900

    Create dedicated class for ironic-ui

    The package name of ironic-ui in Ubnutu/Debian does not follow
    the general naming rule and the existing horizon::dashboard can't be
    used.

    Closes-Bug: #2033929
    Change-Id: I7703550897c6b31f2b45ffce75f0ab2bae7a4157

[Francesco Di Nucci (d1nuc0m)]

Thank you, we'll try it ASAP

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/904001

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/904001
Committed: https://opendev.org/openstack/puppet-horizon/commit/cd60db7031a41f72392d42b317ba52ec3792d3c8
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit cd60db7031a41f72392d42b317ba52ec3792d3c8
Author: Takashi Kajinami <email address hidden>
Date: Mon Nov 13 23:13:18 2023 +0900

    Create dedicated class for ironic-ui

    The package name of ironic-ui in Ubnutu/Debian does not follow
    the general naming rule and the existing horizon::dashboard can't be
    used.

    Closes-Bug: #2033929
    Change-Id: I7703550897c6b31f2b45ffce75f0ab2bae7a4157
    (cherry picked from commit 1219aab8983b1ed44bd5ecab73f1190e44d48ade)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/puppet-horizon/+/904269

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-horizon/+/904269
Committed: https://opendev.org/openstack/puppet-horizon/commit/095080671e8dff944e1f071d0340314c37c2abd2
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 095080671e8dff944e1f071d0340314c37c2abd2
Author: Takashi Kajinami <email address hidden>
Date: Mon Nov 13 23:13:18 2023 +0900

    Create dedicated class for ironic-ui

    The package name of ironic-ui in Ubnutu/Debian does not follow
    the general naming rule and the existing horizon::dashboard can't be
    used.

    Closes-Bug: #2033929
    Change-Id: I7703550897c6b31f2b45ffce75f0ab2bae7a4157
    (cherry picked from commit 1219aab8983b1ed44bd5ecab73f1190e44d48ade)
    (cherry picked from commit cd60db7031a41f72392d42b317ba52ec3792d3c8)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-horizon 24.0.0 release.