Comment 0 for bug 1559189

Testing the latest RC2 for checkbox and I noticed the following messages in the checkbox-ng output when trying for the first time:

There are 0 incomplete sessions that might be resumed
Preparing...
Ignoring invalid instantiated unit Disk statistics for /dev/vda: Problem with field _description: wrong
Ignoring invalid instantiated unit disk/smart_vda: Problem with field _description: wrong
Ignoring invalid instantiated unit disk/read_performance_vda: Problem with field description: wrong
Ignoring invalid instantiated unit disk/storage_device_vda: Problem with field _description: wrong

canonical-certification-server 0.23~c1~ppa~ubuntu15.10.1
canonical-certification-submit 0.23~c1~ppa~ubuntu15.10.1
checkbox-ng 0.24~c2~ppa~ubuntu15.10.1
plainbox-provider-checkbox 0.26~c3~ppa~ubuntu15.10.1
python3-checkbox-ng 0.24~c2~ppa~ubuntu15.10.1
python3-checkbox-support 0.24~c2~ppa~ubuntu15.10.1

And sure enough, in the Test List, they are not present:
[X] + Benchmarks tests │
│ [X] + CPU tests │
│ [X] - Disk tests │
│ [X] disk/detect │
│ [X] disk/stats_vda │
│ [X] + Ethernet Device tests │
│ [X] + Informational tests │
│ [X] + Memory tests │
│ [X] + Miscellaneous tests │
│ [X] + Optical Drive tests │
│ [X] + Power Management tests │
│ [X] + USB tests │
│ [X] + Uncategorised │
│ [X] + Virtualization tests

This was seen in a Digital Ocean droplet running amd64 15.10.

The problem seems to be the format of the description. As it currently sits, the description for Stats, for example, is this:
_description:
 This test checks disk stats, generates some activity and rechecks stats to
 verify they've changed. It also verifies that disks appear in the various
 files they're supposed to.
 .
 This test will inspect the following disk:
 .
     product name: {product}
     sysfs path: {path}
     device node path: /dev/{name}

Replacing instances of {product} with {name} in disk.txt.in resolved the issue for all of it in the Digital Ocean droplet.
I saw similar on a zKVM instance but in that case, changing {product} to {name} did not fix it and I only saw disk/detect as a disk test. Also, on Xenial, I never saw any of hte "Ignoring ..." messages.

We do a lot of testing on KVM and VM type scenarios (PowerVM, PowerKVM, sometimes standalone KVM devices from partners and also eventually z/KVM and z/VM)