Disk tests ignored on VMs
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox Provider - Base |
Fix Released
|
Critical
|
Jeff Lane |
Bug Description
Testing the latest RC2 for checkbox and I noticed the following messages in the checkbox-ng output when trying for the first time:
There are 0 incomplete sessions that might be resumed
Preparing...
Ignoring invalid instantiated unit Disk statistics for /dev/vda: Problem with field _description: wrong
Ignoring invalid instantiated unit disk/smart_vda: Problem with field _description: wrong
Ignoring invalid instantiated unit disk/read_
Ignoring invalid instantiated unit disk/storage_
canonical-
canonical-
checkbox-ng 0.24~c2~
plainbox-
python3-checkbox-ng 0.24~c2~
python3-
And sure enough, in the Test List, they are not present:
[X] + Benchmarks tests │
│ [X] + CPU tests │
│ [X] - Disk tests │
│ [X] disk/detect │
│ [X] disk/stats_vda <---- this appeared AFTER I changed {product} to {name} │
│ [X] + Ethernet Device tests │
│ [X] + Informational tests │
│ [X] + Memory tests │
│ [X] + Miscellaneous tests │
│ [X] + Optical Drive tests │
│ [X] + Power Management tests │
│ [X] + USB tests │
│ [X] + Uncategorised │
│ [X] + Virtualization tests
This was seen in a Digital Ocean droplet running amd64 15.10.
The problem seems to be the format of the description. As it currently sits, the description for Stats, for example, is this:
_description:
This test checks disk stats, generates some activity and rechecks stats to
verify they've changed. It also verifies that disks appear in the various
files they're supposed to.
.
This test will inspect the following disk:
.
product name: {product}
sysfs path: {path}
device node path: /dev/{name}
Replacing instances of {product} with {name} in disk.txt.in resolved the issue for all of it in the Digital Ocean droplet.
I saw similar on a zKVM instance but in that case, changing {product} to {name} did not fix it and I only saw disk/detect as a disk test. Also, on Xenial, I never saw any of hte "Ignoring ..." messages.
We do a lot of testing on KVM and VM type scenarios (PowerVM, PowerKVM, sometimes standalone KVM devices from partners and also eventually z/KVM and z/VM)
Related branches
- Sylvain Pineau (community): Approve
-
Diff: 30 lines (+6/-2)1 file modifiedcheckbox-support/checkbox_support/parsers/udevadm.py (+6/-2)
- Pierre Equoy: Approve
- Jeff Lane : Needs Resubmitting
-
Diff: 42 lines (+18/-0)1 file modifiedcheckbox-support/checkbox_support/parsers/udevadm.py (+18/-0)
description: | updated |
tags: | added: hwcert-server |
summary: |
- Errors when running latest RC2 + Disk tests ignored on VMs |
Changed in plainbox-provider-checkbox: | |
importance: | Undecided → High |
milestone: | none → 0.27 |
Changed in plainbox-provider-checkbox: | |
assignee: | Jeff Lane (bladernr) → Sylvain Pineau (sylvain-pineau) |
status: | Confirmed → In Progress |
Changed in plainbox-provider-checkbox: | |
status: | In Progress → Fix Committed |
Changed in plainbox-provider-checkbox: | |
status: | Fix Committed → Fix Released |
Changed in plainbox-provider-checkbox: | |
assignee: | Sylvain Pineau (sylvain-pineau) → Jeff Lane (bladernr) |
status: | Confirmed → In Progress |
Changed in plainbox-provider-checkbox: | |
status: | In Progress → Fix Committed |
Changed in plainbox-provider-checkbox: | |
milestone: | 0.27 → 0.28 |
Changed in plainbox-provider-checkbox: | |
status: | Fix Committed → Fix Released |
Could you please attach the output of udevadm info --export-db for both VMs, it will help understanding why those devices don't get a valid product value. thanks