Comment 2 for bug 1191928

Revision history for this message
Cameron White (cameronwhite91) wrote : Re: Some strings not translatable

Just making a note of this for later - I think we could do a much better job with adding translations for effects and adjustments to messages.pot. Currently, the SimpleEffectDialog class does some magic to generate a user-friendly string from the EffectData property names (and for enum types). As a result, automated tools (such as our "make updatepot" command) don't recognize those strings as translatable, and we currently add them manually to po/messages.in. Since that file can easily get out of date, we run into issues like this one.

I think we should use the Caption attribute for all of the EffectData properties, and we could then modify the Makefile to automatically recognize those strings as translatable using the --keyword argument to xgettext (http://www.gnu.org/savannah-checkouts/gnu/gettext/manual/html_node/xgettext-Invocation.html). We could probably have some similar attribute for enums to specify the strings as well.