Some strings in effects/adjustments not translatable

Bug #1191928 reported by Hendrik Schrieber
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Pinta
Fix Released
Medium
Cameron White

Bug Description

The following strings are not translatable:

"Open images"
"Hue"
"Saturation"
"Lightness"

The last three are shown when clicking on »Hue/Saturation« in menu »Adjustments«.

Tags: translations
Revision history for this message
Cameron White (cameronwhite91) wrote :

Which version of Pinta are you using? There is no longer a string for "Open Images".

In addition to the saturation dialog, I went through all of the effects and found missing strings for:
- the Polar Inversion effect (Reflect/Warp/etc)
- blend modes for the Clouds effect
- Red/Green/Blue in the Posterize dialog

Changed in pinta:
importance: Undecided → Medium
milestone: none → 1.6
status: New → Confirmed
Revision history for this message
Cameron White (cameronwhite91) wrote :

Just making a note of this for later - I think we could do a much better job with adding translations for effects and adjustments to messages.pot. Currently, the SimpleEffectDialog class does some magic to generate a user-friendly string from the EffectData property names (and for enum types). As a result, automated tools (such as our "make updatepot" command) don't recognize those strings as translatable, and we currently add them manually to po/messages.in. Since that file can easily get out of date, we run into issues like this one.

I think we should use the Caption attribute for all of the EffectData properties, and we could then modify the Makefile to automatically recognize those strings as translatable using the --keyword argument to xgettext (http://www.gnu.org/savannah-checkouts/gnu/gettext/manual/html_node/xgettext-Invocation.html). We could probably have some similar attribute for enums to specify the strings as well.

tags: added: translations
Revision history for this message
Hendrik Schrieber (hennekn) wrote :

I am using Version 1.1.1 in Ubuntu Precise which is a bit outdated.

The OpenImages-Widget is still in the source (trunk) though and this string is the title of that widget in 1.1.1.

Revision history for this message
grofaty (grofaty) wrote :

@hennekn, string "Open Images" existed in Pinta 1.1 and was changed into "Images" in Pinta 1.2 after the following debate in reported bug 886512.

Also Pinta 1.1 was quite buggy. I suggest to upgrade Pinta to currently the latest stable version 1.4 by adding Pinta stable PPA. In Terminal type in bellow commands to upgrade:
sudo add-apt-repository ppa:pinta-maintainers/pinta-stable
sudo apt-get update
sudo apt-get upgrade

P.S. Pinta 1.5 stable is approaching in few days/weeks. This PPA will get updated with new 1.5 version when it is available.

summary: - Some strings not translatable
+ Some strings in effects/adjustments not translatable
no longer affects: ubuntu-translations
Revision history for this message
grofaty (grofaty) wrote :

Today I noticed that: "Hue", "Saturation" and "Lightness" are not translated from »Adjustments« menu »Hue/Saturation« and for my language 100% strings are translated. Searched the Launchpad and this three settings are really missing. Can you please add this settings.

I tried this on Pinta 1.5 on Ubuntu 14.04 installed from official stable PPA.

Revision history for this message
Cameron White (cameronwhite91) wrote :

I've made some partial progress (https://github.com/PintaProject/Pinta/commit/311497c5430f1c754210237444e2440623752e76), so strings like Hue, Saturation, and Lightness are now translatable.

The only remaining issues I'm aware of are the combo boxes that appear for the Polar Inversion and Clouds effects

Changed in pinta:
assignee: nobody → Cameron White (cameronwhite91)
status: Confirmed → In Progress
Revision history for this message
Cameron White (cameronwhite91) wrote :
Changed in pinta:
status: In Progress → Fix Committed
Changed in pinta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.