Comment 2 for bug 1674133

Hi Charles,

I tested your patch, and we're not finished with this bug yet ;-)

In a slightly different testing scenario a segfault occurs.

Steps to reproduce:

1. Configure the command entry to be NOT in the status bar
2. Open the log window
3. Press ":"
4. Enter some characters, e.g. "asdfdhf" (do not execute this command by
   pressing [enter]
5. Mouse click [x] to kill the command entry dialog
6. Press ":"
7. Press esc -> segmentation fault (core dumped)

Yet another testing scenario gives the following violation against the
principle of "least surprise":

1. Configure the command entry to be NOT in the status bar
2. Open the log window
3. Press ":"
4. Enter some characters, e.g. "asdfdhf" (do not execute this command by
   pressing [enter])
5. Press esc to escape from the command entry dialog and to close it ->
   nothing happens

versus:

1. Configure the command entry to be in the status bar
2. Open the log window
3. Press ":"
4. Enter some characters, e.g. "asdfdhf" (do not execute this command by
   pressing [enter])
5. Press esc to escape from the command entry and close it -> user
   experience (UX) as expected

Could you please confirm if these new scenarios happen in the same manner for you ?

PCB needs some more in depth analyses of involved code paths and TLC to
get its behaviour consistent ;-)

On a side note: AFAICT this snippet is in the code base as of 2005/2006
and Dan and DJ last touched this, they may remember why it was put there
in the first place.

With kind regards,

Bert Timmerman.