Last action executed when escaping from command entry

Bug #1674133 reported by Chad Parker on 2017-03-19
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Chad Parker

Bug Description

Steps to reproduce:

1. Configure the command entry to be in the status bar
2. Open the log window
3. Press ":"
4. Enter some characters, e.g. "asdfdhf"
5. Press enter -> "no action asdfdhf()" appears in log window
6. Press ":"
7. Press esc -> "no action asdfdhf()" appears in log window a second time

This is happening because of an else if clause in ghid_handle_user_command:src/hid/gtk/gui-command-window.c. If ghid_command_entry_get returns NULL, then the first if fails, but the second if will succeed if there's anything in the history list, and execute the previous action.

This was clearly done deliberately, but I have no idea why. It seems kind of dangerous to me to execute a previous action if you fail to get a new one.

Chad Parker (parker-charles) wrote :

Branch LP1674133 removes the code that causes this.

Changed in pcb:
assignee: nobody → Chad Parker (parker-charles)
status: New → In Progress
Changed in pcb:
importance: Undecided → High
milestone: none → pcb-4.0.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related blueprints