pcb

Comment 1 for bug 1500042

Revision history for this message
Traumflug (mah-jump-ing) wrote :

Did some whitespace editing to match surrounding code, rebased to latest master, then forwarded it to master.

Application behaviour is now just fine and intuitive. Excellent work!

Regarding refactoring:

- It looks like HID_SC_CENTER_IN_VIEWPORT and HID_SC_PAN_VIEWPORT do pretty much the same, so joining both would reduce code duplication. HID_SC_PAN_VIEWPORT is used for moving the mouse pointer by the keyboard (how ancient are such habits?!) and doesn't really work anyways (once the pointer gets too near to a pin or a via it's caught and can't leave this pin by keyboard operations).

- Making the flags a bitfield could further reduce code duplication, then one could send a ghid_send_crosshair(x, y, HID_SC_WARP_POINTER & HID_SC_PAN_VIEWPORT) to get the both.