pcb

Brittons DRC fixes

Bug #1500042 reported by Traumflug on 2015-09-26
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gEDA project
Low
Unassigned
pcb
Low
Britton Kerin

Bug Description

Whatever the plans are, let them track here and in a like-named bugfix branch.

Traumflug (mah-jump-ing) on 2015-09-26
Changed in geda-project:
importance: Undecided → Low
status: New → In Progress
Traumflug (mah-jump-ing) wrote :

Did some whitespace editing to match surrounding code, rebased to latest master, then forwarded it to master.

Application behaviour is now just fine and intuitive. Excellent work!

Regarding refactoring:

- It looks like HID_SC_CENTER_IN_VIEWPORT and HID_SC_PAN_VIEWPORT do pretty much the same, so joining both would reduce code duplication. HID_SC_PAN_VIEWPORT is used for moving the mouse pointer by the keyboard (how ancient are such habits?!) and doesn't really work anyways (once the pointer gets too near to a pin or a via it's caught and can't leave this pin by keyboard operations).

- Making the flags a bitfield could further reduce code duplication, then one could send a ghid_send_crosshair(x, y, HID_SC_WARP_POINTER & HID_SC_PAN_VIEWPORT) to get the both.

Britton Kerin (britton-kerin) wrote :

I think its best to leave HID_SC_WARP_POINTER and HID_SC_PAN_VIEWPORT around, as they
are visible as a user action and therefore might actually be in use via a script or something
somewhere. However since they don't really work right both they and the user action
should be marked as deprecated. These aren't currently used anywhere besides the action.

Regarding bit field it sounds like a fine way to do it but I'm going to work on some other
problems with DRC first I think.

Changed in pcb:
milestone: none → next-bug-release
importance: Undecided → Low
status: New → In Progress
Changed in pcb:
assignee: nobody → Britton Kerin (britton-kerin)
Changed in pcb:
milestone: next-bug-release → future-bug-release
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers