pcb

The accel key for the settings menu clashes with the accel to increase drill size

Bug #1496603 reported by KaiMartin on 2015-09-16
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
gEDA project
Low
Unassigned
pcb
Medium
Chad Parker

Bug Description

Current git head defines the accel to open the settings menu as [alt-S]. This collides with the accel to increase the drill size of the via or pin under the mouse cursor. Apparently, the menu takes catches the event first. This renders holes impossible to increase via the keyboard.

The drill accel is part of a whole group of related actions. The accels [s], [shift-s], [alt-s], [shift-alt-s] all affect vias and pins. So it's better to not change these in order to resolve the collision.

Proposal: change the accel for the settings menu to [alt-t]. This combo does not seem to be used anywhere.

I attached a rather trivial patch to gpcb-menu.res.in which does just this.

---<)kaimartin(>---

Traumflug (mah-jump-ing) on 2015-09-27
Changed in geda-project:
importance: Undecided → Low
summary: - the accel key for the settingss menu clashes with the accel to increase
+ The accel key for the settingss menu clashes with the accel to increase
drill size
summary: - The accel key for the settingss menu clashes with the accel to increase
+ The accel key for the settings menu clashes with the accel to increase
drill size
KaiMartin (kmk-familieknaak) wrote :

The menu accel keys have been added to pcb fairly recently. Since then the accel to increase hole size is broken. I for one use this feature with almost every layout.
How come. this regression is considered "low" importance? I'd have expected a 'medium'.

---<)kaimartin(>---

Changed in pcb:
status: New → Confirmed
importance: Undecided → Low
milestone: none → next-bug-release
Bert Timmerman (bert-timmerman) wrote :

Alt+V for the "View" pull down menu is affecting the "Via Tool drill + 5 mil" too.

Maybe better to drop the whole accel key for pull down menus functionality.

Kind regards,

Bert Timmeman.

Changed in pcb:
milestone: next-bug-release → future-bug-release
Changed in pcb:
milestone: pcb-4.1.1 → pcb-4.2.1
Chad Parker (parker-charles) wrote :

All keystrokes involving the "alt" key should be remapped.

Changed in pcb:
importance: Low → Medium
Changed in pcb:
assignee: nobody → Chad Parker (parker-charles)
Chad Parker (parker-charles) wrote :

The following are the shortcuts involving the alt key:

<alt-a> Select all
<alt-shift-a> Unselect all (is this really needed?)
<alt-r> Auto route selected rats
<alt-s> Change drill size +5 mils
<alt-shift-s> Change drill size -5 mils
<alt-v> SetValue(ViaDrillingHole, +5, mil)
<alt-shift-v> SetValue(ViaDrillingHole, -5, mil)

These all work fine in the lesstif HID, but alt-s and alt-v are used to access the settings menu and view menu. In order to create the minimum disruption, I'm only going to update the gtk hid for now.

We should consider overhauling the key bindings for the next major release to make them consistent. Like, <key> and shift-<key> be used to interact with objects in the layout (shift making them larger since shift produces capital letters). ctrl-<key> and ctrl-shift-<key> be used to interact with the software for the purposes of things like saving, changing the view, updating route styles, highlighting connections, and such.

For this fix I am going to implement the following mappings:
alt-a --> ctrl-a
alt-shift-a --> ctrl-shift-a
alt-s --> ctrl-d
alt-shift-s --> ctrl-shift-d
alt-v --> ctrl-l
alt-shift-v --> ctrl-shift-l

alt-r will stay alt-r since there isn't presently a conflict, and there isn't really a better combination available.

Chad Parker (parker-charles) wrote :

I've pushed a branch to git that implements these changes in the gtk HID: LP1496603.

Changed in pcb:
status: Confirmed → In Progress
Bert Timmerman (bert-timmerman) wrote :

Hi Chad,

I reviewed, cherry-picked and pushed your commit to master.

I think we should keep the lesstif ky-bindings as close to the gtk key-bindings as possible, I will create an additional commit on the topic branch for review (second pair of eyes).

Kind regards,

Bert Timmerman.

Bert Timmerman (bert-timmerman) wrote :

Hi Chad,

Technically the bug filed by KaiMartin is resolved.

While I'm looking at menu files I found a couple of diffences between the between the gtk and the lesstif menus.

I pushed another commit to decrease the differences a bit.

Another observation is that decreasing/increasing values are hard coded in the menu, for example:

    {"Vias -10 mil" ChangeSize(SelectedVias,-10,mil)}
or

    {"Via Tool size +5 mil" a={"Shift-V" "Shift<Key>v"} SetValue(ViaSize,+5,mil)}

What about metric values ?

Maybe we should review the whole menu system to get rid of hard coded values and units.

I will start a new bug report for this one.

Kind regards,

Bert Timmerman.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers